fix: TextBox, NumberBox, PasswordBox Placeholder Not Working Properly.#1109
Merged
pomianowski merged 1 commit intolepoco:developmentfrom Jun 4, 2024
Merged
fix: TextBox, NumberBox, PasswordBox Placeholder Not Working Properly.#1109pomianowski merged 1 commit intolepoco:developmentfrom
pomianowski merged 1 commit intolepoco:developmentfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
pomianowski
approved these changes
Jun 4, 2024
Contributor
Author
|
In fact, when we set I'm not sure if there is a better solution, or should we put this issue on hold for now, what do you think? @pomianowski |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Passwordis set before settingPlaceholderEnabled, bothPlaceholderTextandPasswordwill appear simultaneously.PlaceholderEnabledisfalseandPlaceholderTextis not empty, clearing Text will still displayPlaceholderText.Issue Number: #1043
What is the new behavior?
PlaceholderEnabledis set tofalseandPlaceholderTextis not empty, clearingTextwill not displayPlaceholderText.Other information
Added a new dependency property
CurrentPlaceholderEnabledProperty.