fix: Clean-up NumberBox: focus repeat event-args debug-output cursor#1328
Merged
pomianowski merged 5 commits intolepoco:mainfrom Feb 1, 2025
Merged
Conversation
github-actions
Bot
added
controls
pomianowski
approved these changes
Feb 1, 2025
pomianowski
added a commit
that referenced
this pull request
Feb 1, 2025
…1328) * fix the NumberBox focus, keyboard, repeat isses, ValueChanged event, and debuggingcode * fix: build warning for not documenting a constructor param * Update NumberBoxValueChangedEventArgs.cs --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
The
Wpf.Ui.Controls.NumberBoxhas several issues. Three of these are described in the following issue numbers:Issue Numbers: #1325, #1326, #1327
#1325 NumberBox focus flashes when using increment, decrement, and clear buttons
#1326 NumberBox holding UpArrow, DownArrow, PageUp, PageDown keys do not repeat, nor do the increment and decrement buttons
#1327 TextBox's IBeam cursor when mouse moves over icon and button margins #1327(#1327)
What is the new behavior?
#1325 NumberBox focus flashes when using increment, decrement, and clear buttons
#1326 NumberBox holding UpArrow, DownArrow, PageUp, PageDown keys do not repeat, nor do the increment and decrement buttons
#1327 TextBox's IBeam cursor when mouse moves over icon and button margins #1327(#1327)
Other information
TODO: Describe the individual changes.