fix: remove all build warnings#1334
Merged
pomianowski merged 2 commits intolepoco:mainfrom Feb 4, 2025
Merged
Conversation
Collaborator
Author
|
A couple of notes:
namespace Wpf.Ui.Interop.Shell32;
/// <summary>
/// The Windows UI provides users with access to a wide variety of objects necessary to run applications and manage the operating system.
/// </summary>
internal static class NativeMethods
{This would require several code changes at all the call sites. However, these could be reduced using this syntax at the top of each file using the interop methods. using Shell32 = Wpf.Ui.Interop.Shell32.NativeMethods;Let me know how you want to proceed. Disable the warning as I have done here, or go through and fix all of them. |
pomianowski
approved these changes
Feb 4, 2025
Member
|
Hey @JohnTasler, thanks for another PR and fixes to the library. Great that you also updated the packages. Changing As for the interop warning, I would think about it in another PR, I created a separate issue where it can be discussed #1338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up all warnings that are generated when building
Wpf.Ui.sln.Pull request type
What is the current behavior?
Issue Numbers: #1332 and #1333
What is the new behavior?
No warnings are generated when building.
Other information
This PR closes #1332. Also closes #1333.