Fix FontSize reference#1413
Merged
pomianowski merged 1 commit intolepoco:mainfrom May 24, 2025
Merged
Conversation
github-actions
Bot
added
controls
pomianowski
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now when using FontIcon in a DLL application (not exe), because of the difference in the order of resource initialisation, the SetResourceReference call overwrites the user-defined value, and binds strictly on the resource value. The patch fixes this and initialises not as a reference but as a value
I think VisualParent check is also unnecessary because FrameworkPropertyMetadataOptions.Inherits is used.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?