Added ClearButtonEnabled property to AutoSuggestBox component (Ref #1439)#1446
Merged
pomianowski merged 5 commits intolepoco:mainfrom Jun 10, 2025
jbryknar:main
Merged
Added ClearButtonEnabled property to AutoSuggestBox component (Ref #1439)#1446pomianowski merged 5 commits intolepoco:mainfrom jbryknar:main
pomianowski merged 5 commits intolepoco:mainfrom
jbryknar:main
Conversation
github-actions
Bot
added
controls
chucker
reviewed
Jun 10, 2025
| return; | ||
| } | ||
|
|
||
| ShowClearButton = !(checkbox?.IsChecked ?? false); |
Collaborator
There was a problem hiding this comment.
Technically, I don't think checkbox can possibly be null here, since you already check that above.
Review comment
pomianowski
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The AutoSuggestBox component now does not allow to use the CleanButtonEnabled property taken from PART_TextBox.
Issue Number: #1439
What is the new behavior?
Other information