fix(controls): ToolTip taking parent line height and font weight into account#1525
Merged
pomianowski merged 1 commit intolepoco:mainfrom Nov 7, 2025
Merged
fix(controls): ToolTip taking parent line height and font weight into account#1525pomianowski merged 1 commit intolepoco:mainfrom
ToolTip taking parent line height and font weight into account#1525pomianowski merged 1 commit intolepoco:mainfrom
Conversation
github-actions
Bot
added
controls
Nuklon
changed the title
pomianowski
changed the title
ToolTip taking parent line height and font weight into account
pomianowski
approved these changes
Nov 7, 2025
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
ToolTip currently sets the internal FontSize to 12, that's OK, but the LineHeight and FontWeight should also be set to ensure that if you have a parent element (e.g., a TextBlock) with say FontWeight SemiBold and LineHeight 28, these don't get used by ToolTip, which looks like a huge amount of padding at the bottom due to the line height.