NavigationView pane toggle button implementation #527
Merged
pomianowski merged 16 commits intolepoco:developmentfrom Feb 11, 2023
Merged
NavigationView pane toggle button implementation #527pomianowski merged 16 commits intolepoco:developmentfrom
NavigationView pane toggle button implementation #527pomianowski merged 16 commits intolepoco:developmentfrom
Conversation
Added FrameMargin property
…has the correct size
IvanDmitriev1
changed the title
NavigationView pane toggle buttonNavigationView pane toggle button implementation
Member
|
Hi, great job. The animation looks very elegant 😄 However, there is a new bug with statically defined menu items. Take a look at the |
Contributor
Author
|
I didn't touch it, yesterday it worked. :( |
Member
|
Pane width breaks for fluent nav |
Member
|
And |
Contributor
Author
|
Should there be such icons ? |
Member
https://apps.microsoft.com/store/detail/winui-3-gallery/9P3JFPWWDZRC |
Member
|
Thanks for the suggestions and contributions. Looks fine to me at this stage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented pane toggle button.
TitleBarnow can be placed in logical order.Added setting default values if the
TitleBarproperty is set inNavigationView.Pull request type