Skip to content

Let TitleBar show 'SystemMenu' on mouse right button up.#627

Merged
pomianowski merged 6 commits intolepoco:developmentfrom
LHTXQ:main
Mar 13, 2024
Merged

Let TitleBar show 'SystemMenu' on mouse right button up.#627
pomianowski merged 6 commits intolepoco:developmentfrom
LHTXQ:main

Conversation

@LHTXQ
Copy link
Copy Markdown
Contributor

@LHTXQ LHTXQ commented May 6, 2023

--- Commit by LHTXQ

Show 'SystemMenu' on mouse right button up.

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Do nothing on mouse right button up.

Issue Number: N/A

What is the new behavior?

Show 'SystemMenu' on mouse right button up.

image

@LHTXQ LHTXQ requested a review from pomianowski as a code owner May 6, 2023 13:57
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 6, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @LHTXQ on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@github-actions github-actions Bot added the controls Changes to the appearance or logic of custom controls. label May 6, 2023
@LHTXQ LHTXQ changed the title Show 'SystemMenu' on mouse right button up. Let TitleBar show 'SystemMenu' on mouse right button up. May 6, 2023
@LHTXQ LHTXQ changed the base branch from main to development May 6, 2023 14:23
@LHTXQ
Copy link
Copy Markdown
Contributor Author

LHTXQ commented May 6, 2023

This is my first pull request, it seems something wrong in the progress, please tell me how to make it right.

@LHTXQ
Copy link
Copy Markdown
Contributor Author

LHTXQ commented May 27, 2023

Maybe we should give the SystemMenua a more modern appearance in keeping with the Wpfui style,but I don't know how to modify it.

In addition, we can also add a function to let user insert or delete menu items in SystemMenu(just like Edge browser's SystemMenu).

@chucker
Copy link
Copy Markdown
Collaborator

chucker commented Sep 6, 2023

Maybe we should give the SystemMenua a more modern appearance in keeping with the Wpfui style,but I don't know how to modify it.

Perhaps it would be easier to replace it with a custom menu altogether. Then we could give people a high-level WPF API where they can simply add additional items, and perhaps boolean properties to remove some default items.

@github-actions github-actions Bot removed the controls Changes to the appearance or logic of custom controls. label Nov 13, 2023
@oli-g-sk
Copy link
Copy Markdown

oli-g-sk commented Dec 7, 2023

Maybe we should give the SystemMenua a more modern appearance in keeping with the Wpfui style,but I don't know how to modify it.

I think even Windows isn't sure about how it's supposed to look like yet. I just checked Notepad (which uses the Fluent look for some time), and the menu looks identical to your screenshot.

image

Then I checked the Settings app, and it's almost the same, but it respects the dark theme.

image

In addition, we can also add a function to let user insert or delete menu items in SystemMenu(just like Edge browser's SystemMenu).

IMO that would be nice, however I would definitely think of it as a separate feature to follow this one.

With this, we're just providing a way to invoke native functionality that was not available (compared to WPF). Something that should just work "out of the box" and doesn't require any "design decisions" as to how to expose it to the users of the library.

@pomianowski pomianowski self-assigned this Mar 13, 2024
@pomianowski pomianowski merged commit eb67db2 into lepoco:development Mar 13, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants