Skip to content

Fix Controls bug#638

Merged
pomianowski merged 3 commits intolepoco:developmentfrom
Maklith:development
Jun 11, 2023
Merged

Fix Controls bug#638
pomianowski merged 3 commits intolepoco:developmentfrom
Maklith:development

Conversation

@Maklith
Copy link
Copy Markdown
Contributor

@Maklith Maklith commented May 14, 2023

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: #635

What is the new behavior?

  1. Fix LeftFluentNavigationViewItemTemplate content fontsize binding
    image
    image

  2. Fix TextBox Icon size,Add two properties to define the icon size and width of the TextBoxClearButton
    Also make icon and the TextBoxClearButton at the center
    image
    image
    image
    It should be like this
    image
    but it is like this
    image
    It only works when I hot reload the binding, I don't know how to fix this

  3. Fix Expander Header fontsize
    image

Other information

  • There are some bugs that need help

@Maklith Maklith requested a review from pomianowski as a code owner May 14, 2023 10:25
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 14, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @makesyt on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@github-actions github-actions Bot added the controls Changes to the appearance or logic of custom controls. label May 14, 2023
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 17, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @makesyt on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@pomianowski pomianowski merged commit 6928a92 into lepoco:development Jun 11, 2023
@niels9001 niels9001 mentioned this pull request Nov 23, 2023
@FluentSk8
Copy link
Copy Markdown

FluentSk8 commented Nov 23, 2023

Is this update released in 3.0.0-preview10? Since this update I can no longer change the FontSize of MenuItems and so they are too big to be displayed if they are longer than 9 characters.

GitWpfUI1

@FluentSk8
Copy link
Copy Markdown

Sorry, can be solved by this. So everything okay.

                <ui:NavigationView.FooterMenuItems>
                    <ui:NavigationViewItem>
                        <ui:NavigationViewItem.Icon>
                            <ui:SymbolIcon Symbol="Settings28" />
                        </ui:NavigationViewItem.Icon>

                        <ui:NavigationViewItem.Content>
                            <TextBlock FontSize="8"
                                       Text="Einstellungen" />
                        </ui:NavigationViewItem.Content>
                    </ui:NavigationViewItem>
                </ui:NavigationView.FooterMenuItems>

@Maklith
Copy link
Copy Markdown
Contributor Author

Maklith commented Nov 23, 2023

Sorry, can be solved by this. So everything okay.抱歉,可以这样解决。所以一切都好。

                <ui:NavigationView.FooterMenuItems>
                    <ui:NavigationViewItem>
                        <ui:NavigationViewItem.Icon>
                            <ui:SymbolIcon Symbol="Settings28" />
                        </ui:NavigationViewItem.Icon>

                        <ui:NavigationViewItem.Content>
                            <TextBlock FontSize="8"
                                       Text="Einstellungen" />
                        </ui:NavigationViewItem.Content>
                    </ui:NavigationViewItem>
                </ui:NavigationView.FooterMenuItems>

this is not a problem caused by this PR, but in a recent update (from someone else), the fact that the FontSize attribute for many controls is invalid if the Content/Header is set directly to the string

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

controls Changes to the appearance or logic of custom controls.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants