Updated NumberBox to use the Width and Height#868
Merged
pomianowski merged 2 commits intolepoco:developmentfrom Dec 11, 2023
Merged
Updated NumberBox to use the Width and Height#868pomianowski merged 2 commits intolepoco:developmentfrom
pomianowski merged 2 commits intolepoco:developmentfrom
Conversation
…Width and Height properties.
…gfix/numberbox-width-issue
pomianowski
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
NumberBoxdefault style'sTemplateto use theTemplateBindingfor theWidthandHeightproperties.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently setting the
Widthproperty of theNumberBoxwill not do anything.Issue Number: N/A
What is the new behavior?
You can set the
NumberBoxWidthandHeightproperties like you would any other control.Other information
The workaround for me has been to put the
NumberBoxinside of aStackPanelor whatever else and set theWidthof that control which is annoying.Some parts of the control are only really designed to for the default
Heightof24so as of now theWidthproperty is more practical to set. I would expect the buttons to be centered vertically and theAccentBorderto be the sameHeightregardless of the control'sHeightinstead of accenting half of the verticalHeight.