Implementation of InfoBadge component#869
Merged
pomianowski merged 6 commits intolepoco:developmentfrom Dec 12, 2023
jbryknar:#798_Add_InfoBadge_for_NavigationViewItems
Merged
Implementation of InfoBadge component#869pomianowski merged 6 commits intolepoco:developmentfrom jbryknar:#798_Add_InfoBadge_for_NavigationViewItems
pomianowski merged 6 commits intolepoco:developmentfrom
jbryknar:#798_Add_InfoBadge_for_NavigationViewItems
Conversation
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
niels9001
reviewed
Dec 11, 2023
Collaborator
Author
|
@niels9001 Thanks for the code review, theme files are not my cup of tea. 😁 |
pomianowski
approved these changes
Dec 12, 2023
Member
|
Hey @jbryknar, thanks for your work and contribution to the project, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #798
The current version of WpfUi does not have an InfoBadge implementation.
What is the new behavior?
Added implementation of InfoBadge component according to Win UI 3.
https://learn.microsoft.com/en-us/windows/apps/design/controls/info-badge
The component can be used as a standalone component:
Supported PaneDisplayMode:
Added InfoBadge page to Status & info section for component demonstration
Other information
Basic parameters
Severity
Styles
Preview
The component can definitely be implemented better and more happily, so I'll be glad for the review and any comments. The goal was to help the author of the project and to contribute a bit to the development of the component.