Update readonly numberbox to prohibit changing values via keyboard / buttons#923
Merged
pomianowski merged 1 commit intolepoco:developmentfrom Feb 3, 2024
Merged
Conversation
… values via keyboard
pomianowski
approved these changes
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
Currently if a numberbox is set to readonly, one can still change the value by keyboard up/down arrow, page up / page down, and the spin buttons.
Issue Number: N/A
What is the new behavior?
If a numberbox is set to readonly, one cannot change its value. Whether by attempting to type a new value, up/down arrows, and the spin buttons are hidden (similar to the existing behavior of how the clear button is hidden).