make NavigationService throw-helpers protected (instead of private)#943
Merged
pomianowski merged 3 commits intolepoco:developmentfrom Mar 13, 2024
Merged
Conversation
so derived class can use them
Palatis
changed the title
NavigationService throw-helpers protectedNavigationService throw-helpers protected (instead of private)
pomianowski
approved these changes
Mar 13, 2024
pomianowski
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
NavigationServicehas their throw-helpers declared withprivatemodifier, which made derived classes difficult.Issue Number: N/A
What is the new behavior?
protectedso they can be used in derived classes.Other information