Don't focus on inline buttons or icons in text input controls when pressing Tab#975
Merged
pomianowski merged 4 commits intolepoco:developmentfrom Mar 13, 2024
tmijail:development
Merged
Don't focus on inline buttons or icons in text input controls when pressing Tab#975pomianowski merged 4 commits intolepoco:developmentfrom tmijail:development
pomianowski merged 4 commits intolepoco:developmentfrom
tmijail:development
Conversation
Set `IsTabStop=False` in the `ClearButton`, `InlineIncrementButton`, `InlineDecrementButton`, and/or `RevealButton` present in `TextBox`, `AutoSuggestBox`, `NumberBox` and `PasswordBox`.
tmijail
commented
Feb 27, 2024
Contributor
Author
tmijail
left a comment
tmijail
left a comment
There was a problem hiding this comment.
Same issue, but with ControlIconLeft and ControlIconRight. I checked AutoSuggestBox, PasswordBox, and TextBox and it seems like those don't have this issue.
tmijail
changed the title
pomianowski
approved these changes
Mar 13, 2024
pomianowski
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid tab-focusing on
ControlIconLeft,ControlIconRight,ClearButton,InlineIncrementButton,InlineDecrementButton, and/orRevealButtonpresent inTextBox,AutoSuggestBox,NumberBoxandPasswordBoxby settingIsTabStop=FalsePull request type
Please check the type of change your PR introduces:
What is the current behavior?
When you press
Tabon a text input control which has inline buttons (ClearButton,InlineIncrementButton,InlineDecrementButton,RevealButton), it focuses on those buttons instead of on the next control.This breaks the flow and is inconsistent with WinUI3.
before.mp4
Issue Number: N/A
What is the new behavior?
Don't focus on buttons in text input controls with Tab.
after.mp4
Other information