ApplicationManager.ApplySystemTheme UpdateAccent fix#994
Merged
pomianowski merged 2 commits intolepoco:developmentfrom Mar 13, 2024
Merged
ApplicationManager.ApplySystemTheme UpdateAccent fix#994pomianowski merged 2 commits intolepoco:developmentfrom
pomianowski merged 2 commits intolepoco:developmentfrom
Conversation
The UpdateAccent flag wasn't set for ApplicationThemeManager.Apply when being triggered from ApplicationThemeManager.ApplySystemTheme, making it default to true.
pomianowski
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Because the
updateAccentisn't forwarded inApplicationThemeManager.ApplySystemTheme(row 236) toApplicationThemeManager.Apply, it defaults totrue.What is the new behavior?
Correctly forwards the set
updateAccentflag.Other information
Losely related to #965.