Clean up and optimize paks #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Splore and Simple Wifi paks (untested, rgb30-specific) - Add DinguxCommander binaries for m17, retroid, rgb30 (SDL2 versions) - Add rgb30/retroid to HTTP File Server and WiFi pak platforms
WiFi.pak now supports IWD-based platforms (PowKiddy RGB30, Retroid Pocket devices) running LessOS. Key changes: - IWD config generation at /storage/.cache/iwd (LessOS persistent storage) - Dynamic WiFi interface detection (not hardcoded to wlan0) - wifictl integration with iwctl fallback for network management - IWD handles DHCP internally (no systemd-networkd needed) - Improved SSID filename sanitization for special characters - Error handling for disk full and permission issues Platforms added: - rgb30: PowKiddy RGB30 - retroid: Retroid Pocket 5, Mini V1/V2, Flip 2
Extract duplicated code (platform normalization, interface detection, system.json handling, process wait loops) into bin/wifi-lib.sh. Reduces code duplication across service-on, service-off, wifi-enabled, and launch.sh. Also fixes hardcoded wlan0 in service-off to use dynamic interface detection.
- Replace xargs with sed for trimming (xargs unavailable on LessOS) - Fix ANSI stripping: use printf '\033' instead of \x1b (busybox sed) - Rewrite IWD enable flow: use iwctl directly with proper device power-on - Filter "Operation already in progress" error from network scan results - Add wait_for_iwd_powered() helper with timeout - Add trim() to shared library
LessUI pak already captures stdout/stderr to log files, so tool paks don't need to manage their own logging. Also replaced fragile "grep for success marker" pattern with proper exit code checking. - Remove exec >> redirects from WiFi, HTTP File Server, System Report - Remove subshell redirects from ADBD, Swap Menu, Apply Panel Fix - Refactor Enable SSH, Bootlogo, Remove Loading to use exit codes - Fix on-boot scripts to use .log extension - Fix HTTP File Server service-on to use .log extension - Combine exec redirects in HTTP File Server on-boot - Remove explicit bash calls in Swap Menu, Apply Panel Fix
There was a problem hiding this comment.
Pull request overview
This PR cleans up and optimizes various paks (package files), with the primary focus on enhancing the WiFi pak to support new platforms (rgb30 and retroid) using IWD (iNet Wireless Daemon) instead of wpa_supplicant. It also includes code refactoring to reduce duplication, removal of redundant logging, and removal of the unused Splore pak.
Key Changes
- Added support for rgb30 and retroid platforms to the WiFi pak with IWD-based networking
- Refactored common WiFi functionality into a shared library (wifi-lib.sh) to reduce code duplication
- Removed unused Splore pak and cleaned up logging in Bootlogo and ADBD paks
Reviewed changes
Copilot reviewed 19 out of 37 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/all/paks/Tools/WiFi/pak.json | Added rgb30 and retroid platforms to supported platforms list |
| workspace/all/paks/Tools/WiFi/launch.sh | Refactored to use shared library functions, added IWD support for new platforms, replaced hardcoded wlan0 with dynamic interface detection |
| workspace/all/paks/Tools/WiFi/bin/wifi-lib.sh | New shared library providing common functions for platform handling, network interface detection, process management, and system.json operations |
| workspace/all/paks/Tools/WiFi/bin/wifi-enabled | Refactored to use shared library functions, added IWD platform support |
| workspace/all/paks/Tools/WiFi/bin/service-on | Refactored to use shared library functions, added IWD platform initialization |
| workspace/all/paks/Tools/WiFi/bin/service-off | Refactored to use shared library functions, added IWD platform cleanup |
| workspace/all/paks/Tools/WiFi/bin/on-boot | Changed log file extension from .txt to .log |
| workspace/all/paks/Tools/WiFi/README.md | Added documentation for rgb30 and retroid platforms |
| workspace/all/paks/Tools/Splore/. | Removed entire Splore pak (all files deleted) |
| workspace/all/paks/Tools/Bootlogo/launch.sh | Removed log file redirects and improved error handling |
| workspace/all/paks/Tools/ADBD/launch.sh | Removed unused PAK_NAME variable and log file redirects |
| workspace/all/paks/Emus/Makefile | Updated PLAYER_CORES_VERSION from 20260101-2 to 20260103-0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.