Faster builds #26
Merged
Faster builds #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves makefile dependency tracking and rebuild efficiency by adding proper header file dependencies and implementing smarter rebuild logic.
- Added
HEADERSvariable with wildcard patterns to track header file changes - Refactored build rules to use proper prerequisites and order-only prerequisites
- Implemented conditional rebuild logic in cores makefile to avoid unnecessary recompilations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/all/syncsettings/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/say/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/minui/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/minput/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/minarch/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/clock/makefile | Added header dependency tracking and restructured build rules with proper prerequisites |
| workspace/all/cores/makefile | Implemented smart rebuild logic that checks timestamps to avoid unnecessary builds |
| makefile.dev | Added header dependency tracking and restructured build rules for macOS development |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have incremental builds. Yippee! Closes #24.