Refactor cores to use externally built minarch-cores #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors LessUI to use externally built libretro cores from the minarch-cores repository, replacing per-platform core compilation with pre-built binaries. It introduces a template-based pak generation system to eliminate duplication across 12 platforms.
Key changes:
- Migration from locally built cores to minarch-cores GitHub releases (nightly builds)
- New pak template system reducing 240+ duplicated
.pakdirectories to ~20 templates - Deprecated gkdpixel platform (marked as no longer supported)
Reviewed Changes
Copilot reviewed 272 out of 569 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| makefile | Replaced local core compilation with minarch-cores download system; added cores-download target |
| scripts/generate-paks.sh | New script to generate platform-specific paks from templates |
| scripts/extract-config-templates.sh | One-time extraction script for creating initial config templates |
| docs/PAK-TEMPLATES.md | Comprehensive documentation of new template system |
| docs/DEVELOPMENT.md | Updated platform list to mark gkdpixel as deprecated |
| docs/ARCHITECTURE.md | Removed gkdpixel from supported devices list |
| SUPPORTED-CORES.md | New documentation listing all 47 supported cores |
| CLAUDE.md | Added pak template system documentation for AI context |
| skeleton/SYSTEM/gkdpixel/paks/Emus/* | Removed deprecated gkdpixel platform pak files |
| skeleton/EXTRAS/Emus//*.pak/ | Removed 132+ duplicated pak directories (now generated from templates) |
| skeleton/EXTRAS/README.md | Updated gkdpixel deprecation notice with bold formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our initial integration. There are a number of issues with the cores themselves and various devices, but we'll dig into their fixes core by core and platform by platform.