Add new logging system #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive logging system for LessUI, replacing the previous ad-hoc logging approach with a unified, well-documented solution for both C code and shell scripts.
Key Changes:
- New C logging API (
log.h/log.c) with automatic timestamps, errno translation, and log rotation - Shell script logging library (
log.sh) for boot/install scripts - Standardized log file naming convention (
.txt→.logacross all platforms)
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/all/common/log.{h,c} | Core logging implementation with thread-safe file rotation |
| workspace/all/common/log_internal.h | Internal structures for logging system |
| tests/unit/all/common/test_log.c | Comprehensive unit tests (498 lines) |
| workspace/all/{minui,minarch}/minui.c, minarch.c | Integrated new logging system, removed \n from messages |
| workspace/all/common/{utils,api}.c | Updated file I/O functions with error logging |
| workspace/*/keymon/{makefile,keymon.c} | Added log.c compilation, imported log.h |
| skeleton/SYSTEM/*/paks/MinUI.pak/launch.sh | Renamed log files from .txt to .log |
| skeleton/SYSTEM/common/log.sh | New shell logging library with rotation |
| docs/LOGGING.md | Comprehensive 881-line documentation |
| makefile.{qa,dev} | Added log.c to test builds and dev environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 60 out of 60 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nchapman
force-pushed
the
feature/app-logging
branch
from
fa5cfc8 to
223d57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.