-
Notifications
You must be signed in to change notification settings - Fork 0
List enhancements #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Crashes on miyoomini.
df76052 to
301966a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the list view system in MinUI (the ROM launcher) with three major improvements: (1) asynchronous thumbnail loading using a background thread to prevent UI stutter during scrolling, (2) natural sorting with article handling ("Game 2" < "Game 10", "The Zelda" sorts under "L"), and (3) comprehensive No-Intro ROM naming convention parser that strips metadata tags and normalizes display names.
Key changes:
- Adds pthread-based async thumbnail loader with request superseding and fade-in animation
- Implements natural sort comparison (strnatcasecmp) with leading article skipping
- Adds No-Intro parser to clean ROM names and handle article rearrangement
- Introduces sort_key field to Entry structure for consistent sorting and alphabetical indexing
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/all/minui/minui.c | Adds async thumbnail loader thread, Entry sort_key field, integrates natural sort and No-Intro parser |
| workspace/all/common/str_compare.c/h | Implements natural string comparison with article skipping |
| workspace/all/common/nointro_parser.c/h | Parses No-Intro ROM naming convention tags |
| workspace/all/common/utils.c/h | Integrates No-Intro parser into getDisplayName(), adds fixArticle() helper |
| workspace/all/common/gfx_text.c | Improves text truncation edge case for very short strings |
| makefile.qa | Adds test targets for new string comparison and No-Intro parser functionality |
| tests/unit/all/common/test_*.c | Comprehensive test coverage for new functionality |
| docs/list-views.md | Documents list view features and implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.