Integrate MinUI updates #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported bug fixes from upstream MinUI (github.com/shauninman/MinUI): - rg35xxplus: Fix mid-poweroff resume on newer OFW by adding sleep after poweroff - zero28: Fix screen not turning on after sleep on some board revisions - tg5040: New Helaas-based limbo fix with direct AXP power management - my355: Fix right analog stick axes (swap RX/RY) Credit: Shaun Inman <shaun@panic.com> Co-Authored-By: Shaun Inman <shaun@panic.com>
Ported Mini Flip features from upstream MinUI: - keymon.c: Add USB audio detection via GPIO45/44 polling - checkUSB() monitors speaker/headphone switching - Updates volume setting when audio output changes - Runs checks every 500ms alongside battery monitoring - Add getInt/putInt helpers for sysfs access - msettings.c: Separate speaker and headphone volumes - Add headphones and jack fields to settings struct - Version migration from v1 to v2 settings - GetVolume/SetVolume now jack-aware - SetJack updates volume when switching outputs Note: show.c and batmon.c already had 640x480 framebuffer forcing. Note: platform.c already had lid detection, wifi status, model detection. Credit: Shaun Inman <shaun@panic.com> Co-Authored-By: Shaun Inman <shaun@panic.com>
There was a problem hiding this comment.
Pull request overview
This PR integrates various MinUI platform updates and bug fixes across multiple handheld gaming devices, including improvements to hardware detection, LED control, audio management, and shutdown procedures.
Key Changes
- Hardware-specific fixes: Added brightness workaround for zero28 board revisions, corrected axis mappings for my355 controller
- Audio enhancements: Implemented USB audio detection and headphone jack support for Miyoo Mini Flip with proper settings versioning and migration
- LED control improvements: Fixed inverted LED logic in tg5040 to correctly reflect enabled/disabled states
- Shutdown refinements: Streamlined tg5040 shutdown script by removing debug logging and simplifying AXP power management calls
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/zero28/platform/platform.c | Added SetRawBrightness(8) call before restoring user brightness to fix screen wake issues on certain board revisions |
| workspace/tg5040/platform/platform.c | Corrected LED enable logic (inverted parameter) and updated documentation to match actual behavior (60=on, 0=off); added PLAT_enableBacklight call during poweroff |
| workspace/rg35xxplus/boot/boot.sh | Added 60-second sleep after poweroff command (purpose unclear - may be workaround for async shutdown) |
| workspace/my355/platform/platform.h | Swapped AXIS_RX and AXIS_RY mappings (3↔4) to correct right analog stick orientation |
| workspace/miyoomini/libmsettings/msettings.c | Incremented settings version to 2; added headphones volume and jack state fields with migration logic; implemented proper headphone/speaker volume switching based on jack detection |
| workspace/miyoomini/keymon/keymon.c | Added USB audio detection for Mini Flip via GPIO45/44; refactored battery monitoring thread to also poll USB state every 500ms; fixed initialization order (settings before ADC checks) |
| skeleton/SYSTEM/tg5040/bin/shutdown | Replaced complex shutdown procedure with direct AXP register writes for cleaner poweroff; removed debug logging to /mnt/UDISK |
| skeleton/SYSTEM/rg35xxplus/bin/shutdown | Added 60-second sleep after poweroff command (purpose unclear - may be workaround for async shutdown) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.