Fix frame pacing for SDL1 platforms #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running 30fps games (e.g., Spyro on PCSX) with aspect scaling, frame pacing repeats frames to match ~60Hz display. SDL1 platforms were unconditionally flipping double-buffer pages, causing stale data to be displayed on repeated frames. Added two-flag system mirroring SDL2's ctx->blit pattern: - vid.renderer: tracks game mode (persists until menu) - vid.in_game: tracks new frame this vsync (cleared each flip) miyoomini: skip blit on repeated frames (vid.video retains content) trimuismart/rg35xx: select previous page via display_page calculation
nchapman
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running 30fps games (e.g., Spyro on PCSX) with aspect scaling, frame pacing repeats frames to match ~60Hz display. SDL1 platforms were unconditionally flipping double-buffer pages, causing stale data to be displayed on repeated frames.
Added two-flag system mirroring SDL2's ctx->blit pattern: