[HLW8012] Fix setting calibration via command #4895
+37
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonhuisman
reviewed
Nov 30, 2023
| bool valid = false; | ||
| if (static_cast<int>(_current) == 0) getCurrent(valid); | ||
| if (valid && static_cast<int>(_current) > 0) _current_multiplier *= (value / _current); | ||
| if (valid && static_cast<int>(_current) > 0) _current_multiplier *= (expected / _current); |
Contributor
There was a problem hiding this comment.
Will valid ever be set to true, if _current is already greater than 0, when calling this method? If not, then the multiplier won't be set, AFAICS...
Member
Author
There was a problem hiding this comment.
Only when _power != 0, or when there is an interrupt while executing this function.
But with this PR I will no longer just call getCurrent() when updating the calibration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4893