-
Notifications
You must be signed in to change notification settings - Fork 1
chore: QAT-2656 - improve slack success report #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: QAT-2656 - improve slack success report #6
Conversation
Pull Request Test Coverage Report for Build 14177809726Details
💛 - Coveralls |
maximiliano-soler-deel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the Slack success report functionality by enabling options to exclude success reports for specific teams and to split team reports when multiple tags are set for the same channel. It adds new test cases for both success and failure reports, updates the Slack reporter configuration to support split reporting, and enhances documentation in the README.md.
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/results_parser/parse_success_results_by_pattern.spec.ts | Adds new tests with the shouldSplitTeamReports flag and updated report options |
| tests/results_parser/parse_failure_results_by_pattern.spec.ts | Updates failure report tests to include the shouldSplitTeamReports flag |
| src/SlackReporter.ts | Introduces shouldSplitTeamReports and an excludeSuccessReport option in team channels |
| src/ResultsParser.ts | Adds splitTestPatterns support, introduces combineChannelResults, and updates grouping logic |
| README.md | Updates documentation to reflect new reporting options |
Files not reviewed (2)
- package.json: Language not supported
- tests/test_data/valid_test_results_by_teams.json: Language not supported
Description:
New options available in order to:
excludeSuccessReport)splitTeamReports)Also:
Related issue:
QAT-2656
Check list: