Skip to content

Conversation

@emanuel-ponce-deel
Copy link
Contributor

@emanuel-ponce-deel emanuel-ponce-deel commented Mar 31, 2025

Description:

New options available in order to:

  • exclude success report for a certain team (boolean excludeSuccessReport)
  • split team reports when multiple tags are set for the same channel (boolean splitTeamReports)

Also:

  • previous test logs were removed
  • improved test coverage

Related issue:
QAT-2656

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@emanuel-ponce-deel emanuel-ponce-deel requested a review from a team March 31, 2025 17:29
@coveralls
Copy link

coveralls commented Mar 31, 2025

Pull Request Test Coverage Report for Build 14177809726

Details

  • 26 of 29 (89.66%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 78.06%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SlackReporter.ts 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
src/SlackReporter.ts 1 61.07%
Totals Coverage Status
Change from base Build 14129270174: 1.8%
Covered Lines: 340
Relevant Lines: 419

💛 - Coveralls

@emanuel-ponce-deel emanuel-ponce-deel requested a review from a team March 31, 2025 17:31
Copy link

@maximiliano-soler-deel maximiliano-soler-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the Slack success report functionality by enabling options to exclude success reports for specific teams and to split team reports when multiple tags are set for the same channel. It adds new test cases for both success and failure reports, updates the Slack reporter configuration to support split reporting, and enhances documentation in the README.md.

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/results_parser/parse_success_results_by_pattern.spec.ts Adds new tests with the shouldSplitTeamReports flag and updated report options
tests/results_parser/parse_failure_results_by_pattern.spec.ts Updates failure report tests to include the shouldSplitTeamReports flag
src/SlackReporter.ts Introduces shouldSplitTeamReports and an excludeSuccessReport option in team channels
src/ResultsParser.ts Adds splitTestPatterns support, introduces combineChannelResults, and updates grouping logic
README.md Updates documentation to reflect new reporting options
Files not reviewed (2)
  • package.json: Language not supported
  • tests/test_data/valid_test_results_by_teams.json: Language not supported

@emanuel-ponce-deel emanuel-ponce-deel merged commit e7036ea into main Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants