Summary
FileOperationsTest::SetUp creates its scratch directory as %TEMP%\lockr_tests - a name left over
from a previous rename of the project (the binary, repo, and CMake target are all called seal).
This is harmless at runtime but confuses newcomers reading the test code and leaves stale-looking
artefacts in %TEMP%.
Suggested implementation
- m_TestDir = std::filesystem::temp_directory_path() / "lockr_tests";
+ m_TestDir = std::filesystem::temp_directory_path() / "seal_tests";
Steps to reproduce
# Inspect tests/test_integration.cpp line 128:
# m_TestDir = std::filesystem::temp_directory_path() / "lockr_tests";
Expected behaviour
The temp directory name reflects the current project: seal_tests (matching the GoogleTest
executable name seal_tests.exe).
Actual behavior
tests/test_integration.cpp:128:
m_TestDir = std::filesystem::temp_directory_path() / "lockr_tests";
The name "lockr" does not appear anywhere else in the source tree of the current project.
Relevant log output
# Not applicable - the failure is contextual
seal version
main @ b00bd86
Pre-submission checklist
Summary
FileOperationsTest::SetUpcreates its scratch directory as%TEMP%\lockr_tests- a name left overfrom a previous rename of the project (the binary, repo, and CMake target are all called seal).
This is harmless at runtime but confuses newcomers reading the test code and leaves stale-looking
artefacts in
%TEMP%.Suggested implementation
Steps to reproduce
Expected behaviour
The temp directory name reflects the current project:
seal_tests(matching the GoogleTestexecutable name
seal_tests.exe).Actual behavior
tests/test_integration.cpp:128:m_TestDir = std::filesystem::temp_directory_path() / "lockr_tests";The name "lockr" does not appear anywhere else in the source tree of the current project.
Relevant log output
# Not applicable - the failure is contextualseal version
main @ b00bd86
Pre-submission checklist