Skip to content

Add verifyPacket crypto tests#4

Merged
lextpf merged 1 commit into
lextpf:mainfrom
snoopuppy582:test/verifypacket-coverage
May 12, 2026
Merged

Add verifyPacket crypto tests#4
lextpf merged 1 commit into
lextpf:mainfrom
snoopuppy582:test/verifypacket-coverage

Conversation

@snoopuppy582
Copy link
Copy Markdown
Contributor

Summary

  • Adds verifyPacket() coverage next to the existing crypto packet tests.
  • Covers valid packets, wrong passwords, and corrupted packets.
  • Keeps the change test-only; no cryptography behavior changes.

Fixes #2.

Tests

  • uvx clang-format -i tests/test_crypto.cpp
  • uvx clang-format --dry-run --Werror tests/test_crypto.cpp
  • git diff --check

Notes

  • I could not run seal_tests locally because this workspace does not have the repo's vcpkg toolchain/dependencies installed (..\vcpkg\scripts\buildsystems\vcpkg.cmake is missing). The GitHub Actions test workflow builds this on windows-latest with vcpkg.

@lextpf
Copy link
Copy Markdown
Owner

lextpf commented May 12, 2026

Hi @snoopuppy582,

Thanks for jumping in so quickly, having another pair of eyes on this is always appreciated! 😊
Your changes look good and you have my approval! I'll merge this back ASAP

If you'd like to dive in deeper as a contributer:

The project is a bit opaque about where assets live and it's a bit tricky to set up your own assets which means runtime testing can be quite cumbersome, if you'd like to test locally yourself here are two easy ways to get you up and running in case you want to be more hands-on for future issues:

What you might need How to get it Notes
Full pre-built project from your branch ➜ Add me on Discord (@lextpf). Unzip anywhere and run the executable.
Only the assets (if you want to build yourself) ➜ Add me on Discord (@lextpf). After cloning the repo, drop the assets/ folder from this ZIP into the repo root, then build.

Let me know if you need support and we can arrange something, and thanks again for volunteering and helping improve Seal, you're always welcome to work on future issues! 🦭

Alex

@lextpf lextpf self-assigned this May 12, 2026
@snoopuppy582
Copy link
Copy Markdown
Contributor Author

snoopuppy582 commented May 12, 2026

Thanks, Alex. The test workflow is passing on this branch. The sonar failure appears to happen before analysis because SONAR_TOKEN is empty and SonarCloud reports a project/token permission issue, so it does not look related to this test-only change. The build workflow is still sitting in Configure CMake.

@lextpf lextpf merged commit af0fcf9 into lextpf:main May 12, 2026
2 of 3 checks passed
@lextpf
Copy link
Copy Markdown
Owner

lextpf commented May 12, 2026

Bypassed due to SonarQube for now because the token isn't wired correctly in our CI/CD, I'll look into this separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for Cryptography::verifyPacket

2 participants