Skip to content

Remove redundant token clone in config step#103

Merged
leynos merged 1 commit intocodex/add-cucumber-test-for-cooldown_period_seconds-defaultfrom
codex/refactor-lint-suppression-in-config_steps.rs
Sep 14, 2025
Merged

Remove redundant token clone in config step#103
leynos merged 1 commit intocodex/add-cucumber-test-for-cooldown_period_seconds-defaultfrom
codex/refactor-lint-suppression-in-config_steps.rs

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Sep 14, 2025

Summary

  • clean up config_without_cooldown test step by moving token instead of cloning
  • drop obsolete lint expectations

Testing

  • make lint
  • make test

https://chatgpt.com/codex/tasks/task_e_68c74d4e59888322a11c483c739a6966

Summary by Sourcery

Simplify the config_without_cooldown test step by moving the token instead of cloning it and removing obsolete lint expectations.

Enhancements:

  • Pass token by value to config_file_with_token instead of cloning it.

Tests:

  • Remove outdated Clippy expect annotations for needless_pass_by_value and redundant_clone lints.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Sep 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactor the config_without_cooldown test step to eliminate unnecessary token cloning and obsolete lint expectation annotations, streamlining the code and cleaning up obsolete clippy directives.

File-Level Changes

Change Details Files
Remove redundant token clone and obsolete lint expectations
  • Dropped #[expect] attributes for clippy::needless_pass_by_value and clippy::redundant_clone
  • Replaced token.clone() with direct token move in config_file_with_token call
tests/steps/config_steps.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/refactor-lint-suppression-in-config_steps.rs

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leynos leynos merged commit deb3225 into codex/add-cucumber-test-for-cooldown_period_seconds-default Sep 14, 2025
2 of 3 checks passed
@leynos leynos deleted the codex/refactor-lint-suppression-in-config_steps.rs branch September 14, 2025 23:27
leynos added a commit that referenced this pull request Sep 14, 2025
* Add Cucumber test for default cooldown

* Suppress Clippy pass-by-value warning in config step

* Remove redundant token clone in config step (#103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant