Remove redundant token clone in config step#103
Merged
leynos merged 1 commit intocodex/add-cucumber-test-for-cooldown_period_seconds-defaultfrom Sep 14, 2025
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactor the config_without_cooldown test step to eliminate unnecessary token cloning and obsolete lint expectation annotations, streamlining the code and cleaning up obsolete clippy directives. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
deb3225
into
codex/add-cucumber-test-for-cooldown_period_seconds-default
2 of 3 checks passed
leynos
added a commit
that referenced
this pull request
Sep 14, 2025
leynos
added a commit
that referenced
this pull request
Sep 14, 2025
* Add Cucumber test for default cooldown * Suppress Clippy pass-by-value warning in config step * Remove redundant token clone in config step (#103)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make lintmake testhttps://chatgpt.com/codex/tasks/task_e_68c74d4e59888322a11c483c739a6966
Summary by Sourcery
Simplify the config_without_cooldown test step by moving the token instead of cloning it and removing obsolete lint expectations.
Enhancements:
Tests: