Skip to content

Throttle worker retries in tests#50

Open
leynos wants to merge 1 commit intomainfrom
xlt29z-codex/update-cooldown-period-and-json-payload
Open

Throttle worker retries in tests#50
leynos wants to merge 1 commit intomainfrom
xlt29z-codex/update-cooldown-period-and-json-payload

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Aug 4, 2025

Summary

  • ensure worker retries are throttled during tests
  • return minimal comment payload from mock to satisfy Octocrab

Testing

  • make fmt
  • make lint
  • make test

https://chatgpt.com/codex/tasks/task_e_68910b5a65088322bd9067dfddbec71a

Summary by Sourcery

Ensure worker retries are throttled in tests and update mock comment responses to return minimal Octocrab-compatible payload.

Enhancements:

  • Set a positive cooldown_period_seconds in tests to throttle worker retries

Tests:

  • Update mock server response to include minimal JSON fields (id and body) for Octocrab comment API

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 4, 2025

Reviewer's Guide

Tests now simulate realistic worker retry throttling by enforcing a positive cooldown and adjust the GitHub comment mock to return the minimal JSON payload required by Octocrab.

Sequence diagram for worker retry throttling in tests

sequenceDiagram
    participant Test as Test Runner
    participant Config as Config
    participant Worker as Worker
    Test->>Config: Set cooldown_period_seconds = 1
    Test->>Worker: Start worker with config
    loop On retry
        Worker->>Config: Check cooldown_period_seconds
        Worker-->>Worker: Wait 1 second before retry
    end
Loading

Sequence diagram for mock GitHub comment response in tests

sequenceDiagram
    participant Test as Test Runner
    participant MockServer as MockServer
    participant Octocrab as Octocrab
    Test->>MockServer: Setup POST /repos/o/r/issues/1/comments
    MockServer-->>Octocrab: Respond with {"id": 1, "body": "b"}
    Octocrab-->>Test: Receives minimal valid comment payload
Loading

Class diagram for updated test configuration and mock response

classDiagram
    class Config {
        +int cooldown_period_seconds
        ...
    }
    class MockServer
    class Mock
    class ResponseTemplate
    class Octocrab
    class Receiver
    class channel
    class temp_config
    class tempdir

    setup_run_worker --> Config : uses
    setup_run_worker --> MockServer : uses
    setup_run_worker --> Octocrab : uses
    setup_run_worker --> Receiver : uses
    setup_run_worker --> channel : uses
    setup_run_worker --> temp_config : uses
    setup_run_worker --> tempdir : uses
    MockServer --> Mock : mounts
    Mock --> ResponseTemplate : responds_with
    ResponseTemplate : +set_body_json()
    Config : +cooldown_period_seconds = 1 (in tests)
Loading

File-Level Changes

Change Details Files
Throttle worker retries during tests by introducing a cooldown period
  • Changed cooldown_period_seconds from 0 to 1 in test config setup
crates/comenqd/src/daemon.rs
Return minimal JSON payload in comment mock to satisfy Octocrab
  • Replaced raw '{}' response with set_body_json containing id and body fields
crates/comenqd/src/daemon.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 4, 2025

Warning

Rate limit exceeded

@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 453d723 and 989ffdd.

📒 Files selected for processing (1)
  • crates/comenqd/src/daemon.rs (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch xlt29z-codex/update-cooldown-period-and-json-payload

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant