Fix CodeScene step condition by leynos · Pull Request #9 · leynos/ddlint

leynos · 2025-06-24T22:36:27Z

Summary

ensure the CI workflow only runs the CodeScene upload step when the secret is present

Testing

make fmt
make lint
make test

https://chatgpt.com/codex/tasks/task_e_685b22cb5530832288028be8e6da3a06

Summary by Sourcery

Ensure the CodeScene coverage upload step in the CI workflow only runs when the access token secret is non-empty

Bug Fixes:

Fix CodeScene upload step to require a non-empty secret value

CI:

Update GitHub Actions condition to check that CS_ACCESS_TOKEN is not an empty string

sourcery-ai · 2025-06-24T22:36:32Z

Reviewer's Guide

Refines the GitHub Actions CI workflow by tightening the conditional on the CodeScene coverage upload step so it only runs when the CS_ACCESS_TOKEN secret is present and non-empty.

File-Level Changes

Change	Details	Files
Enhanced CodeScene upload step guard	Replaced truthy check on `secrets.CS_ACCESS_TOKEN` with an explicit non-empty string comparison	`.github/workflows/ci.yml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

coderabbitai · 2025-06-24T22:36:33Z

Summary by CodeRabbit

Chores
- Updated continuous integration workflow to improve handling of environment variables and action versions.
- Simplified the formatting check in the Makefile by removing Markdown formatting verification and related dependencies.

Walkthrough

This update modifies the CI workflow configuration and the Makefile. The CI workflow now sets environment variables for CodeScene integration more explicitly, updates the CodeScene upload action version, and changes how secrets are referenced. The Makefile's check-fmt target no longer depends on tools or checks Markdown formatting.

Changes

File(s)	Change Summary
.github/workflows/ci.yml	Explicitly sets CodeScene environment variables, updates upload action version, and alters secret handling.
Makefile	Removes `tools` dependency and Markdown formatting check from `check-fmt` target.

Possibly related PRs

Replace workflow with CI job ortho-config#38: Also modifies CI workflow and environment variable handling for CodeScene integration.
Switch coverage upload to CodeScene mdtablefix#12: Changes CI workflow to use environment variables for CodeScene and updates the upload action, similar to this PR.
Fix env block in upload-codescene-coverage action shared-actions#13: Adjusts how CS_ACCESS_TOKEN and CODESCENE_CLI_SHA256 are exported and used in the CodeScene upload action, closely related to this PR's workflow changes.

Poem

A rabbit hops through lines of code,
Where secrets and tokens once overflowed.
Now with variables set just right,
And formatting checks made light,
The CI runs swift, the carrots bestowed! 🥕

— CodeRabbit

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment
Commit Unit Tests in branch codex/fix-invalid-workflow-file-at-line-32

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sourcery-ai

Hey @leynos - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

leynos · 2025-06-24T23:12:53Z

@coderabbitai review

coderabbitai · 2025-06-24T23:12:59Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

leynos · 2025-06-24T23:51:16Z

@coderabbitai review

coderabbitai · 2025-06-24T23:51:23Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

leynos · 2025-06-24T23:59:04Z

@coderabbitai review

coderabbitai · 2025-06-24T23:59:10Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

leynos · 2025-06-25T00:26:12Z

@coderabbitai review

coderabbitai · 2025-06-25T00:26:19Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ade219 and 2e75000.

📒 Files selected for processing (2)

.github/workflows/ci.yml (2 hunks)
Makefile (1 hunks)

🔇 Additional comments (2)

Makefile (1)

42-44: ```shell
#!/bin/bash
set -e

echo "=== Searching for mdformat-all in Makefile ==="
rg -n "mdformat-all" -A2 -B2 Makefile || echo "No mdformat-all references found."

echo
echo "=== Searching for check-fmt target in Makefile ==="
rg -n "^check-fmt:" -A3 -B3 Makefile || echo "check-fmt target not found."

echo
echo "=== Searching for fmt: target in Makefile ==="
rg -n "^fmt:" -A3 -B3 Makefile || echo "fmt: target not found."
</details>
<details>
<summary>.github/workflows/ci.yml (1)</summary>

`34-40`: To verify if there’s a default set for installer-checksum (and thus whether omitting it could still work), let’s fetch the full action.yml and inspect its inputs:


```shell
#!/bin/bash
set -e

curl -s https://raw.githubusercontent.com/leynos/shared-actions/v1.1.1/.github/actions/upload-codescene-coverage/action.yml \
  | sed -n '1,200p'

Fix CodeScene step condition

6e006e2

leynos added the codex label Jun 24, 2025 — with ChatGPT Codex Connector

sourcery-ai Bot reviewed Jun 24, 2025

View reviewed changes

Update CodeScene step env

766a732

Update format check rule

2e75000

coderabbitai Bot requested changes Jun 25, 2025

View reviewed changes

Comment thread .github/workflows/ci.yml

leynos merged commit 37ec035 into main Jun 25, 2025
2 checks passed

leynos deleted the codex/fix-invalid-workflow-file-at-line-32 branch June 25, 2025 02:01

coderabbitai Bot approved these changes Jun 25, 2025

View reviewed changes

coderabbitai Bot mentioned this pull request Jul 5, 2025

Add Codecov upload to CI leynos/wireframe#182

Merged

Conversation

leynos commented Jun 24, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

leynos commented Jun 24, 2025

Uh oh!

coderabbitai Bot commented Jun 24, 2025

Uh oh!

leynos commented Jun 24, 2025

Uh oh!

coderabbitai Bot commented Jun 24, 2025

Uh oh!

leynos commented Jun 24, 2025

Uh oh!

coderabbitai Bot commented Jun 24, 2025

Uh oh!

leynos commented Jun 25, 2025

Uh oh!

coderabbitai Bot commented Jun 25, 2025

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

leynos commented Jun 24, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Jun 24, 2025 •

edited

Loading

coderabbitai Bot commented Jun 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)