Skip to content

Fix markdownlint errors#52

Open
leynos wants to merge 1 commit intomainfrom
codex/fix-markdownlint-errors-in-markdown-files
Open

Fix markdownlint errors#52
leynos wants to merge 1 commit intomainfrom
codex/fix-markdownlint-errors-in-markdown-files

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Jun 16, 2025

Summary

  • fix docs markdown formatting for lint

Testing

  • markdownlint **/*.md
  • cargo fmt --all
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-targets --all-features
  • nixie docs/rust-testing-with-rstest-fixtures.md docs/testing-differential-datalog-rulesets.md

https://chatgpt.com/codex/tasks/task_e_684f78315e1c83229e1cc060ffd9137b

Summary by Sourcery

Fix markdownlint formatting errors in documentation by standardizing fenced code blocks, specifying proper languages, and adding lint directives for long table lines.

Documentation:

  • Standardize code block fences with appropriate language identifiers in rstest and DDlog documentation
  • Add markdownlint-disable/enable directives around long tables to suppress MD013 errors
  • Correct inconsistent fence lengths and remove stray text inside code samples

Summary by CodeRabbit

  • Documentation
    • Improved formatting and consistency of code blocks and tables for better readability.
    • Enhanced syntax highlighting by adding correct language identifiers to code examples.
    • Refined indentation, spacing, and inline code styling in documentation.
    • Made minor textual adjustments for clarity and flow without altering content.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 16, 2025

Walkthrough

This update refines the formatting and presentation of two documentation files by correcting code block language tags, improving code snippet readability, and enhancing markdown consistency. No functional or logical changes are made; all modifications are stylistic to improve clarity and correctness in the documentation.

Changes

File(s) Change Summary
docs/rust-testing-with-rstest-fixtures.md Fixed code block language tags, improved code formatting, added/removal of markdownlint directives, minor prose adjustments.
docs/testing-differential-datalog-rulesets.md Refined table formatting, corrected code block language identifiers, minor prose edits, and improved code block consistency.

Possibly related PRs

Suggested reviewers

  • codescene-delta-analysis

Poem

In the garden of docs where code blocks bloom,
A rabbit hops by with a markdown broom.
Syntax now sparkles, tags in their place,
Indents align with elegant grace.
No logic disturbed, just clarity's cheer—
Documentation shines, crystal and clear!
🐇✨

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch codex/fix-markdownlint-errors-in-markdown-files
  • Post Copyable Unit Tests in Comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jun 16, 2025

Reviewer's Guide

This PR addresses markdownlint errors by normalizing code block fences (consistent backtick counts and language labels), refining blank-line spacing around code samples, reformatting tables for proper alignment, and inserting lint directives around long tables to satisfy MD013.

File-Level Changes

Change Details Files
Normalized Markdown code fences
  • Standardized backtick counts and fence closures
  • Updated language tags on code blocks (rust, toml, ddlog)
  • Removed stray inline labels preceding fences
docs/rust-testing-with-rstest-fixtures.md
docs/testing-differential-datalog-rulesets.md
Refined blank-line spacing
  • Inserted missing blank lines before and after code blocks
  • Removed extra blank lines within samples
docs/rust-testing-with-rstest-fixtures.md
docs/testing-differential-datalog-rulesets.md
Reformatted markdown tables
  • Aligned table columns and separators
  • Removed stray horizontal separators in table markup
docs/testing-differential-datalog-rulesets.md
Inserted markdownlint directives
  • Disabled MD013 before long tables
  • Re-enabled MD013 after tables
docs/testing-differential-datalog-rulesets.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78a25eb and 2a6e75c.

📒 Files selected for processing (2)
  • docs/rust-testing-with-rstest-fixtures.md (8 hunks)
  • docs/testing-differential-datalog-rulesets.md (15 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-test
🔇 Additional comments (2)
docs/rust-testing-with-rstest-fixtures.md (1)

108-113: Code fence language tagging is correct.

The TOML snippet is properly fenced with toml and closed correctly. This aligns with markdownlint requirements.

docs/testing-differential-datalog-rulesets.md (1)

1329-1344: Markdownlint directives correctly scoped.

Disabling MD013 around the attribute reference table is appropriate to preserve readability of long table rows. The enable/disable markers are properly placed.

Comment on lines +180 to +194
| ---------------------- | -------------------------------------------------- |
------------------------------------------------------------- | | start; |
`program.transaction_start()` | Begins a new transaction to batch input changes.
| | insert MyRel(f1=v1); | `program.apply_updates(vec![insert MyRel(f1=v1)])` |
Adds new facts to an input relation. | | delete MyRel(f1=v1); |
`program.apply_updates(vec![delete MyRel(f1=v1)])` | Removes facts from an input
relation. | | commit; | `program.transaction_commit()` | Applies batched changes
without immediately returning deltas. | | commit dump_changes; |
`program.transaction_commit_dump_changes()` | Applies batched changes and
retrieves deltas. | | dump MyOutputRel; |
`program.dump_table(MyOutputRel::relid())` | Retrieves the full contents of an
output relation. | | rollback; | `program.transaction_rollback()` | Discards
pending changes in the current transaction. | | clear MyRel; |
`program.clear_relation(MyRel::relid())` | Removes all records from a relation
within a transaction. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Malformed markdown table syntax.

The CLI-to-API mapping table rows lack consistent pipe delimiters and proper three-column alignment, which will break rendering. Please ensure every table row begins and ends with | and contains exactly three cells: the DDlog CLI command, the Rust API call, and its purpose. For example:

-| start; | `program.transaction_start()` | Begins a new transaction to batch input changes |
+| start; | `program.transaction_start()` | Begins a new transaction to batch input changes |

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In docs/testing-differential-datalog-rulesets.md between lines 180 and 194, the
markdown table showing CLI-to-API mappings is malformed with inconsistent pipe
delimiters and incorrect column alignment. Fix this by ensuring each table row
starts and ends with a pipe character and contains exactly three columns: the
DDlog CLI command, the Rust API call, and the description. Align the pipes
properly to maintain a consistent three-column table format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant