Conversation
Rewrite contains_strong to avoid unstable let chain syntax. Run fmt to update formatting.
Reviewer's GuideThis PR refactors the HTML parser to eliminate unstable let-chains in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Rate limit exceeded@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/wrap.rs:52` </location>
<code_context>
}
impl PrefixHandler {
- fn build_bullet_prefix(cap: &Captures) -> String { cap[1].to_string() }
</code_context>
<issue_to_address>
The module is missing a `//!` module-level comment at the top.
Please add a `//!` comment at the very top of the file to describe the module's purpose, as required by the review instructions.
</issue_to_address>
### Comment 2
<location> `src/html.rs:85` </location>
<code_context>
}
impl PrefixHandler {
- fn build_bullet_prefix(cap: &Captures) -> String { cap[1].to_string() }
</code_context>
<issue_to_address>
The module is missing a `//!` module-level comment at the top.
Please add a `//!` comment at the very top of the file to describe the module's purpose, as required by the review instructions.
</issue_to_address>
### Comment 3
<location> `src/io.rs:36` </location>
<code_context>
}
impl PrefixHandler {
- fn build_bullet_prefix(cap: &Captures) -> String { cap[1].to_string() }
</code_context>
<issue_to_address>
The module is missing a `//!` module-level comment at the top.
Please add a `//!` comment at the very top of the file to describe the module's purpose, as required by the review instructions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -51,11 +51,17 @@ struct PrefixHandler { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
issue (review_instructions): The module is missing a //! module-level comment at the top.
Please add a //! comment at the very top of the file to describe the module's purpose, as required by the review instructions.
Review instructions:
Path patterns: **/*.rs
Instructions:
Every module must begin with a //! comment.
| @@ -84,7 +84,9 @@ fn is_element(handle: &Handle, tag: &str) -> bool { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
issue (review_instructions): The module is missing a //! module-level comment at the top.
Please add a //! comment at the very top of the file to describe the module's purpose, as required by the review instructions.
Review instructions:
Path patterns: **/*.rs
Instructions:
Every module must begin with a //! comment.
| pub fn rewrite(path: &Path) -> std::io::Result<()> { | ||
| rewrite_with(path, process_stream) | ||
| } | ||
|
|
There was a problem hiding this comment.
issue (review_instructions): The module is missing a //! module-level comment at the top.
Please add a //! comment at the very top of the file to describe the module's purpose, as required by the review instructions.
Review instructions:
Path patterns: **/*.rs
Instructions:
Every module must begin with a //! comment.
|
Superseded by #170 |
1 participant
Summary
contains_strongto avoid unstable let chainsTesting
make lintmake testhttps://chatgpt.com/codex/tasks/task_e_688d273069a8832299abb344bd7a85d5
Summary by Sourcery
Remove unstable Rust syntax in the HTML parser, standardize utility functions to block syntax, and apply formatting fixes across code and docs
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores: