Simplify strong detection with iterator

[leynos]

Summary

• use iterator any for checking bold descendants

Testing

• cargo clippy -- -D warnings
• RUSTFLAGS="-D warnings" cargo test
• markdownlint -c .markdownlint-cli2.jsonc '**/*.md' (fails: multiple pre-existing lint issues)
• nixie docs/

---

https://chatgpt.com/codex/tasks/task_e_684e2cab760c83228a15b803959ef0b5

Summary by Sourcery

Enhancements:

• Use Iterator::any to streamline the recursive check for <strong> descendants instead of a manual loop.

Summary by CodeRabbit

• Refactor
  • Improved internal code readability and efficiency with a more concise implementation. No changes to user-facing functionality.

[sourcery-ai]

Reviewer's Guide

Replaces the manual recursive loop for detecting <strong> descendants with a more concise use of the any iterator combinator to streamline the contains_strong function.

Class Diagram for html.rs Module and updated contains_strong Function

classDiagram
  class Handle {
    <<DataType>>
    children: Iterable~Handle~
  }
  class html_rs {
    <<Rust Module>>
    +contains_strong(handle: &Handle) bool
  }
  html_rs ..> Handle : uses

Loading

File-Level Changes

Change	Details	Files
Simplified recursive strong element detection using iterator any	Replaced explicit for loop and if check with handle.children.borrow().iter().any(contains_strong) Removed trailing false return as it’s now implicit in any	src/html.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Walkthrough

The function contains_strong in src/html.rs was refactored to use a more concise iterator-based approach. The explicit recursive for loop was replaced with the .any() iterator method, maintaining the original recursive logic but simplifying the code structure. No public interfaces or control flow were changed.

Changes

File(s)	Change Summary
src/html.rs	Refactored contains_strong to use .any() for recursion.

Poem

In the warren of code, a loop once did roam,
Now .any() hops swiftly, no need to comb.
The logic unchanged, but the path is more clear,
A concise little tweak that brings us good cheer.
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/html.rs (1)

102-103: Optional: minimise borrow scope for clarity
Consider extracting the borrow into a local variable to reduce borrow scope and improve readability:

-   handle.children.borrow().iter().any(contains_strong)
+   let children = handle.children.borrow();
+   children.iter().any(contains_strong)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38e4ad6 and b373587.

📒 Files selected for processing (1)

• src/html.rs (1 hunks)

🔇 Additional comments (1)

src/html.rs (1)

95-103: Refactored contains_strong to idiomatic iterator usage
The new implementation using .any() preserves the original recursive logic while eliminating the explicit loop. It’s concise and behaviourally equivalent.

[sourcery-ai]

Hey @leynos - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}