Add missing table reflow test cases

[leynos]

Summary

• add two malformed table fixtures and expected results
• handle escaped horizontal rules when parsing tables
• detect inline separator rows and format them correctly
• extend integration tests with new table cases

Testing

• cargo fmt -- --check
• cargo clippy -- -D warnings
• RUSTFLAGS="-D warnings" cargo test

---

https://chatgpt.com/codex/tasks/task_e_684e91bb15908322979c2ec23a0430dc

Summary by Sourcery

Enhance table reflow to skip escaped horizontal rules, detect inline separator rows, and correctly format malformed tables, and add integration tests with fixtures for new cases.

Bug Fixes:

• Handle escaped horizontal rules and inline separator rows correctly when reflowing tables

Enhancements:

• Remove invalid default separators and leverage actual separator rows from input during table formatting

Tests:

• Add integration tests and fixtures for month_seconds and offset malformed table cases

[sourcery-ai]

Reviewer's Guide

Enhance table reflow to skip escaped separators, correctly detect and format inline separator rows, refine consistency checks, and expand integration tests with two new malformed table cases.

File-Level Changes

Change	Details	Files
Filter out escaped horizontal rules from table lines	Add a filter step to remove lines starting with "-" during trimming	src/lib.rs
Detect and remove inline separator rows	Introduce sep_cells and sep_row_idx to track separator content and position If initial separator is invalid, check second row for separator pattern Remove detected separator row from output_rows	src/lib.rs
Refine row consistency and output construction	Adjust mismatch detection to ignore rows consisting solely of separator patterns Switch from using cleaned rows to output_rows for building final output	src/lib.rs
Refactor separator padding logic	Use sep_cells variable to pad and format separator cells Rename local variable for clarity	src/lib.rs
Add new integration tests with fixtures	Add two tests for month_seconds and offset table cases Include corresponding input and expected data files	tests/integration.rs tests/data/month_seconds_input.txt tests/data/month_seconds_expected.txt tests/data/offset_table_input.txt tests/data/offset_table_expected.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Warning

Rate limit exceeded

@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b452a9 and a606e34.

📒 Files selected for processing (6)

• src/lib.rs (4 hunks)
• tests/data/month_seconds_expected.txt (1 hunks)
• tests/data/month_seconds_input.txt (1 hunks)
• tests/data/offset_table_expected.txt (1 hunks)
• tests/data/offset_table_input.txt (1 hunks)
• tests/integration.rs (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @leynos - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[leynos]

@coderabbitai new github issue:

Please refactor reflow_table() in lib.rs using the "extract function" technique. Consider moving the new related functions to a new reflow.rs file.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@leynos I'll create a GitHub issue for refactoring the reflow_table() function as requested.

---

🏁 Script executed:

#!/bin/bash

# Create a GitHub issue for refactoring reflow_table() function
gh issue create \
  --title "Refactor reflow_table() function using extract function technique" \
  --body "## Description

The \`reflow_table()\` function in \`lib.rs\` should be refactored using the \"extract function\" technique to improve code maintainability and readability.

## Scope

- Refactor the \`reflow_table()\` function by extracting smaller, focused functions
- Consider moving the new related functions to a new \`reflow.rs\` file for better organisation

## Context

This refactoring request was made by @leynos to improve the codebase structure.

## References

- Pull Request: https://github.com/leynos/mdtablefix/pull/42
- Original Comment: https://github.com/leynos/mdtablefix/pull/42#issuecomment-$(gh api repos/:owner/:repo/issues/comments --jq '.[] | select(.body | contains(\"extract function\")) | .id' | head -1)

Requested by: @leynos" \
  --assignee leynos

Length of output: 1087

---

Perfect! I've successfully created GitHub issue #43 for refactoring the reflow_table() function. The issue has been:

• Created with the title "Refactor reflow_table() function using extract function technique"
• Assigned to you (@leynos)
• Linked to this PR for context
• Scoped to include both the extract function technique and consideration for moving related functions to a new reflow.rs file

You can view the issue at: #43

The issue is ready for implementation when you're ready to tackle this refactoring work!