Skip to content

Fix markdown fenced code block languages#52

Merged
leynos merged 3 commits intomainfrom
codex/fix-markdownlint-violations-and-commit-changes
Jun 16, 2025
Merged

Fix markdown fenced code block languages#52
leynos merged 3 commits intomainfrom
codex/fix-markdownlint-violations-and-commit-changes

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Jun 16, 2025

Summary

  • run mdformat-all
  • fix missing code block languages in docs

Testing

  • cargo +nightly-2025-06-10 fmt --all
  • cargo +nightly-2025-06-10 clippy -- -D warnings
  • RUSTFLAGS="-D warnings" cargo test
  • markdownlint docs/rust-testing-with-rstest-fixtures.md

https://chatgpt.com/codex/tasks/task_e_68502d97529c83228a701e006ef6f1c2

Summary by Sourcery

Format Markdown documentation and add missing language specifiers to fenced code blocks

Documentation:

  • Reformat Markdown files with mdformat-all for consistent styling
  • Add language identifiers to fenced code blocks to enable proper syntax highlighting

Summary by CodeRabbit

  • Documentation
    • Improved formatting and readability of documentation for HTML table support.
    • Extensively revised and expanded the Rust testing with rstest fixtures guide, adding clearer explanations, more detailed examples, and enhanced formatting for better instructional quality. No technical content or functionality was changed.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jun 16, 2025

Reviewer's Guide

This PR applies mdformat-all to rewrap and normalize markdown in the docs, and annotates all fenced code blocks with explicit language specifiers (e.g., rust, toml) to improve readability and syntax highlighting.

Flow diagram for documentation code block rendering before and after PR

flowchart TD
    A[Markdown documentation] --> B{Fenced code block}
    B -- No language specifier (before PR) --> C[No syntax highlighting]
    B -- Language specifier added (after PR) --> D[Syntax highlighting enabled]
    C --> E[Lower readability]
    D --> F[Improved readability]
Loading

File-Level Changes

Change Details Files
Standardized markdown formatting
  • Reflowed and wrapped paragraphs to a consistent line width
  • Unified indentation and whitespace
  • Ran mdformat-all across documentation files
docs/rust-testing-with-rstest-fixtures.md
docs/html-table-support.md
Added explicit language tags to code fences
  • Annotated Rust code blocks with rust</li><li>Annotated TOML code blocks with toml
  • Ensured every fenced block includes a language identifier
docs/rust-testing-with-rstest-fixtures.md
Minor doc adjustments in HTML table guide
  • Reflowed description of convert_html_tables function
  • Removed trailing blank lines
docs/html-table-support.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 16, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update revises two documentation files for improved readability and clarity. The changes include reformatting paragraphs, adding code fences, refining language, expanding explanations, and converting tables to Markdown format. No technical content or code logic was altered, and no exported or public entities were changed.

Changes

File(s) Change Summary
docs/html-table-support.md Reformatted documentation text for readability by breaking long sentences into multiple lines.
docs/rust-testing-with-rstest-fixtures.md Extensively revised for formatting, clarity, expanded explanations, more examples, and Markdown table formatting.

Possibly related PRs

Poem

In the warren where docs are spun,
Clearer words and tables begun.
Fences for code, examples anew,
Markdown shines with a readable hue.
Rabbits hop with editorial delight—
Documentation now crisp and bright!
🐇✨

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch codex/fix-markdownlint-violations-and-commit-changes
  • Post Copyable Unit Tests in Comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes - here's some feedback:

  • The ```toml fenced block in docs/rust-testing-with-rstest-fixtures.md is closed immediately after the opening—move the closing fence below the Cargo.toml lines so they’re correctly included in the block.
  • There’s an unmatched closing ``` at the end of docs/html-table-support.md—either remove it or add the corresponding opening fence with the proper language label.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The ```toml fenced block in docs/rust-testing-with-rstest-fixtures.md is closed immediately after the opening—move the closing fence below the Cargo.toml lines so they’re correctly included in the block.
- There’s an unmatched closing ``` at the end of docs/html-table-support.md—either remove it or add the corresponding opening fence with the proper language label.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leynos
Copy link
Copy Markdown
Owner Author

leynos commented Jun 16, 2025

@sourcery-ai review

@leynos
Copy link
Copy Markdown
Owner Author

leynos commented Jun 16, 2025

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 16, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes - here's some feedback:

  • In html-table-support.md there’s a trailing code fence that isn’t annotated or correctly closed—please add the proper language specifier and ensure matching opening/closing backticks for that snippet.
  • Double-check that every fenced code block across both docs has a language tag; I spotted at least one example in html-table-support.md still missing one.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In html-table-support.md there’s a trailing code fence that isn’t annotated or correctly closed—please add the proper language specifier and ensure matching opening/closing backticks for that snippet.
- Double-check that every fenced code block across both docs has a language tag; I spotted at least one example in html-table-support.md still missing one.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leynos leynos merged commit d294fc8 into main Jun 16, 2025
3 checks passed
@leynos leynos deleted the codex/fix-markdownlint-violations-and-commit-changes branch June 16, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant