Improve indentation handling in renumber_lists

[leynos]

Summary

• optimise renumber_lists by slicing the leading whitespace instead of allocating a String

Testing

• make fmt
• make lint
• make test

---

https://chatgpt.com/codex/tasks/task_e_68763897bcc883229487e1c8e853443b

Summary by Sourcery

Enhancements:

• Slice leading whitespace to compute indentation length instead of collecting chars into a String

[sourcery-ai]

Reviewer's Guide

Optimize renumber_lists by slicing leading whitespace instead of allocating a String for indentation measurement

File-Level Changes

Change	Details	Files
Optimize indentation measurement to avoid heap allocation	Removed collecting leading whitespace into a new String Computed indent_end using char_indices and find Sliced the input line to obtain indent_str	src/lib.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Summary by CodeRabbit

• Refactor
  • Improved the efficiency of indentation measurement for list renumbering, resulting in optimised performance without changing existing functionality.

Walkthrough

Refactor the renumber_lists function to optimise indentation measurement by directly identifying the index of the first non-whitespace character, eliminating the need for intermediate string allocation. Preserve the existing logic while improving performance by slicing the original line instead of creating a new string.

Changes

File(s)	Change Summary
src/lib.rs	Refactor renumber_lists to measure indentation directly from the original line, removing unnecessary string allocation.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant renumber_lists

    Caller->>renumber_lists: Call with input lines
    renumber_lists->>renumber_lists: Find index of first non-whitespace char
    renumber_lists->>renumber_lists: Slice original line for indentation
    renumber_lists->>renumber_lists: Measure indentation length
    renumber_lists-->>Caller: Return processed lines

Loading

Possibly related PRs

• Refactor list renumbering #69: Refactors renumber_lists with new helper functions and logic changes, modifying the same function at a different abstraction level.
• Add --renumber option to mdtablefix #54: Introduces and modifies the renumber_lists function, directly related to the refactored implementation.

Poem

Whitespace wrangled, strings set free,
Indentation measured with swift esprit.
No more clones or needless strain,
Just slicing lines, efficiency gained.
Code that’s lean, precise, and neat—
A tidy feat, a coder’s treat!
🧹✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e649bf and d6f9d14.

📒 Files selected for processing (1)

• src/lib.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

• AGENTS.md

⚙️ CodeRabbit Configuration File

🔇 Additional comments (1)

src/lib.rs (1)

681-687: Excellent optimisation avoiding unnecessary allocation.

The refactoring efficiently measures indentation by finding the first non-whitespace character index and slicing the original line, eliminating the intermediate string allocation. The logic is equivalent to the previous implementation whilst being more performant.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/optimize-indentation-measurement-to-avoid-allocations

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @leynos - I've reviewed your changes and found some issues that need to be addressed.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}