Merged
Conversation
Contributor
Reviewer's GuideIntroduces File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Summary by CodeRabbit
WalkthroughIntroduce the Changes
Sequence Diagram(s)sequenceDiagram
participant TestFunction
participant include_lines! macro
participant FileSystem
TestFunction->>include_lines! macro: Invoke with file path
include_lines! macro->>FileSystem: Embed file contents at compile time
include_lines! macro->>include_lines! macro: Split contents into lines
include_lines! macro->>TestFunction: Return Vec<String> of file lines
TestFunction->>TestFunction: Use Vec<String> in test assertions
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes - here's some feedback:
- Consider scoping the include_lines! macro locally in the test module (e.g. via #[macro_use]) rather than #[macro_export] to avoid polluting the crate namespace.
- There’s some overlap between include_lines! and the existing lines_vec! macro—consider consolidating or clearly differentiating their roles in tests/common to reduce redundancy.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider scoping the include_lines! macro locally in the test module (e.g. via #[macro_use]) rather than #[macro_export] to avoid polluting the crate namespace.
- There’s some overlap between include_lines! and the existing lines_vec! macro—consider consolidating or clearly differentiating their roles in tests/common to reduce redundancy.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
tests/common/mod.rs(1 hunks)tests/integration.rs(5 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- AGENTS.md
⚙️ CodeRabbit Configuration File
🧬 Code Graph Analysis (1)
tests/integration.rs (2)
src/html.rs (1)
convert_html_tables(299-342)src/table.rs (1)
reflow_table(95-132)
🔇 Additional comments (1)
tests/integration.rs (1)
468-471: Nice swap toinclude_lines!– compile-time embedding removes I/O and simplifies the tests.No further issues spotted; calls are clear and paths remain relative to the test file, so the build will fail fast if a fixture is missing.
Also applies to: 475-477, 486-488, 493-495, 500-502, 509-511, 521-523, 782-784, 862-864
Owner
Author
|
@coderabbitai pause |
Contributor
✅ Actions performedReviews paused. |
Owner
Author
|
@coderabbitai resume |
Contributor
✅ Actions performedReviews resumed. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
tests/common/mod.rs(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🔇 Additional comments (1)
tests/common/mod.rs (1)
21-23: Macro implementation is concise and idiomaticUsing
map(str::to_owned).collect()achieves the minimal iterator chain previously requested and keeps the macro hygienic. No further action required.
This was referenced Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_lines!macro totests/commoninclude_lines!inintegration.rsTesting
make fmtmake lintmake testhttps://chatgpt.com/codex/tasks/task_e_6878ddd802ac8322904f1c36d4b5e862
Summary by Sourcery
Introduce an include_lines! macro to streamline loading test fixtures and refactor existing integration tests to leverage it for cleaner, more concise code.
New Features:
Enhancements:
Tests: