Skip to content

Gate Diesel backends with Cargo features#79

Open
leynos wants to merge 1 commit intomainfrom
codex/update-diesel-and-diesel-async-dependencies
Open

Gate Diesel backends with Cargo features#79
leynos wants to merge 1 commit intomainfrom
codex/update-diesel-and-diesel-async-dependencies

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Jun 11, 2025

Summary

  • disable default Diesel features and add sqlite/postgres features
  • enable Diesel and diesel-async backend support via Cargo features
  • require feature selection when building
  • silence markdownlint line-length warnings

Testing

  • cargo clippy --features sqlite -- -D warnings
  • cargo test --features sqlite (fails: ReturningClause not supported for Sqlite)
  • markdownlint README.md docs/supporting-both-sqlite3-and-postgresql-in-diesel.md
  • nixie docs/supporting-both-sqlite3-and-postgresql-in-diesel.md README.md

https://chatgpt.com/codex/tasks/task_e_6848cc3408d4832294d6f7e4ae78005b

Summary by Sourcery

Gate Diesel and Diesel-async backends behind explicit Cargo features, disable their default features, and update documentation to require selecting either the sqlite or postgres feature when building.

New Features:

  • Add sqlite and postgres Cargo features to enable corresponding Diesel and Diesel-async backends

Enhancements:

  • Disable default features for diesel, diesel-async, and libsqlite3-sys dependencies
  • Add bundled libsqlite3-sys dependency for sqlite support

Build:

  • Require explicit feature selection for database backends in Cargo.toml

Documentation:

  • Update README and supporting documentation to instruct building with --features sqlite or --features postgres
  • Silence markdownlint line-length warnings in documentation

Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jun 11, 2025

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant