Refactor src/manifest.rs: Split module into focused submodules (≤400-line limit)

[coderabbitai]

Overview

The src/manifest.rs module currently exceeds the project's ≤400-line limit and needs to be decomposed into focused submodules to reduce complexity and improve code organization.

Proposed Submodule Decomposition

manifest/yaml_diag.rs

• YamlDiagnostic type and implementation
• map_yaml_error function
• to_span utility
• Error hints and diagnostic helpers

manifest/jinja_helpers.rs

• env_var function
• render_* functions (template rendering utilities)
• eval_expression function
• Template processing helpers

manifest/glob.rs

• Glob normalisation utilities
• Path validation logic
• Glob pattern processing

Keep in src/manifest.rs

• Main manifest structure definitions
• Public API surface
• Module re-exports and coordination

Benefits

• Adherence to project's ≤400-line standard
• Reduced module complexity
• Improved separation of concerns by functionality
• Enhanced maintainability and testability
• Clearer organization of YAML diagnostics, Jinja processing, and glob handling

Context

This refactoring requirement was identified during code review of PR #152.

Reference: #152

[leynos]

@coderabbitai looking at the codebase, is this issue still relevant? If the issue has been fixed in the code, does the documentation reflect this?

If it is still relevant, please provide an assessment of the issue criticality (critical, high, medium or low), based on risk of the issue impacting the user and the anticipated blast radius.

Once a decision has been made, apply the appropriate label.

If the issue is documentation ONLY (i.e., no code changes needed), apply the documentation label in addition to the appropriate criticality label.

Please also provide an impact of the required changes.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch details of issue #157
gh issue view 157 --json title,body,labels,state

Length of output: 1357

---

🏁 Script executed:

#!/bin/bash
# Check if src/manifest.rs exists and count lines
if [ -f "src/manifest.rs" ]; then
    echo "=== src/manifest.rs exists ==="
    wc -l src/manifest.rs
    echo ""
    echo "=== File structure preview (first 50 lines) ==="
    head -n 50 src/manifest.rs
else
    echo "src/manifest.rs does not exist"
fi

echo ""
echo "=== Check for proposed submodules ==="
ls -la src/manifest/ 2>/dev/null || echo "No src/manifest/ directory found"

echo ""
echo "=== Check for any manifest-related files ==="
fd -e rs manifest

Length of output: 915

---

🏁 Script executed:

#!/bin/bash
echo "=== Line counts for all src/manifest/ files ==="
wc -l src/manifest/*.rs

echo ""
echo "=== Check mod.rs structure (first 80 lines) ==="
head -n 80 src/manifest/mod.rs

echo ""
echo "=== Check for documentation about manifest module ==="
echo "--- Checking README.md ---"
if [ -f "README.md" ]; then
    grep -i "manifest" README.md -A 3 -B 1 || echo "No mentions of manifest in README.md"
fi

echo ""
echo "--- Checking for docs directory ---"
fd -t f . docs/ 2>/dev/null | head -20 || echo "No docs directory found"

echo ""
echo "--- Check for architecture or design docs ---"
fd -t f -e md . | grep -iE "(arch|design|structure)" | head -10

Length of output: 5042

---

🏁 Script executed:

#!/bin/bash
echo "=== Check design documents for manifest module info ==="
grep -l "manifest" docs/*.md

echo ""
echo "=== Check netsuke-design.md specifically ==="
grep -i "manifest\|module\|400.*line" docs/netsuke-design.md -A 2 -B 2 | head -50

echo ""
echo "=== Check for any coding standards or style guide ==="
grep -i "400.*line\|line.*limit\|module.*size" docs/*.md -H | head -20

Length of output: 2691

---

🏁 Script executed:

#!/bin/bash
# Apply the "medium" criticality label to issue #157
gh issue edit 157 --add-label "medium"

Length of output: 44

---

@leynos, I've completed my analysis of issue #157. Here's my assessment:

Issue Status: Still Relevant (Partially Complete)

The refactoring has been partially completed but the goal has not been fully achieved:

✅ Completed:

• src/manifest.rs has been successfully decomposed into src/manifest/ directory with 8 submodules
• Main coordination logic moved to mod.rs (239 lines - within limit)
• Some proposed submodules created: glob.rs, diagnostics.rs, render.rs, expand.rs, hints.rs

❌ Still Outstanding:

Four files still exceed the ≤400-line limit:

• glob.rs: 525 lines (+125 over limit)
• jinja_macros.rs: 443 lines (+43 over limit)
• diagnostics.rs: 415 lines (+15 over limit)
• tests.rs: 412 lines (+12 over limit)

Documentation Status

This is an internal code quality refactoring with no user-facing changes. Documentation updates are not required. Therefore, I have not applied the documentation label.

Criticality Assessment: MEDIUM

I've applied the medium label based on:

• ✅ Low risk: Internal refactoring, no functional changes
• ✅ Low blast radius: Doesn't impact users or external APIs
• ⚠️ Maintainability concern: Violates project standards for module complexity
• ⚠️ Technical debt: Should be addressed to prevent further growth

Impact of Required Changes

Scope: Further decomposition of 4 oversized modules

Effort: Low to Medium

• glob.rs (525 lines): Moderate effort - needs careful splitting of glob utilities
• jinja_macros.rs (443 lines): Moderate effort - likely contains related macro definitions
• diagnostics.rs (415 lines): Low effort - only 15 lines over
• tests.rs (412 lines): Low effort - only 12 lines over, could split by test categories

Risk: Very Low - purely structural changes with no behavioural modifications expected

Recommendations:

1. Prioritise glob.rs (most over limit) - consider splitting into normalisation, validation, and pattern processing submodules as originally proposed
2. jinja_macros.rs could be split into helper registration vs. macro implementations
3. diagnostics.rs and tests.rs are barely over and may just need minor extraction of utilities