CI: update action SHAs across workflows and remove version input#257
CI: update action SHAs across workflows and remove version input#257
Conversation
The rust-build-release shared action only accepts target, project-dir, and bin-name inputs. The version parameter was incorrectly passed during the PR #253 refactor, causing the CI warning "Unexpected input(s) 'version'" and subsequent "Unable to locate executable file: undefined" error during macOS builds. The version input remains correctly passed to packaging actions (macos-package, windows-package, linux-packages) where it is a valid parameter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refreshes pinned SHAs for all custom leynos/shared-actions GitHub Actions used in CI, build, packaging, and release workflows, and simplifies the build-and-package workflow by removing an unused version input from the Rust build and packaging steps that was causing macOS input resolution errors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughUpdate GitHub Actions commit references across four workflow files to newer commits. Changes include bumping versions for Rust setup, build, packaging, and release automation actions. No functional logic or workflow structure modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Updates shared-actions pin from df81280dcc to bd92b1e6f7. The new version includes a fix for sccache no longer being published for macOS x86_64, which was causing the "Unable to locate executable file: undefined" error during macOS builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates shared-actions pin from df81280dcc to bd92b1e6f7. The new version includes a fix for sccache no longer being published for macOS x86_64, which was causing the "Unable to locate executable file: undefined" error during macOS builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR description mentions updating actions to SHA
bd92b1e6..., but the workflows are actually pinned to7f4cc573...; consider aligning the description and any internal references with the actual SHAs being used to avoid confusion when debugging CI later. - Since all shared actions are now pinned to the same commit SHA (
7f4cc573...), it may be helpful to add a brief comment or reference to the corresponding shared-actions version/tag in one place (e.g., at the top of each workflow) so future updates can be done consistently and intentionally.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR description mentions updating actions to SHA `bd92b1e6...`, but the workflows are actually pinned to `7f4cc573...`; consider aligning the description and any internal references with the actual SHAs being used to avoid confusion when debugging CI later.
- Since all shared actions are now pinned to the same commit SHA (`7f4cc573...`), it may be helpful to add a brief comment or reference to the corresponding shared-actions version/tag in one place (e.g., at the top of each workflow) so future updates can be done consistently and intentionally.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@coderabbitai Have the following now been resolved? The PR description mentions updating actions to SHA |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 172 🏁 Script executed: Length of output: 7692 🏁 Script executed: Length of output: 2106
Current state:
Recommendation: |
|
@coderabbitai can you make the necessary changes to the PR description? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 9476
The description already references SHA
The incorrect SHA ( |
Summary
Changes
CI Workflow
.github/workflows/build-and-package.yml, updated action SHAs for packaging and build steps:leynos/shared-actions/.github/actions/rust-build-release@7f4cc57326d14b55f7eea300e0454653636fb6a1leynos/shared-actions/.github/actions/linux-packages@7f4cc57326d14b55f7eea300e0454653636fb6a1leynos/shared-actions/.github/actions/stage-release-artefacts@7f4cc57326d14b55f7eea300e0454653636fb6a1leynos/shared-actions/.github/actions/windows-package@7f4cc57326d14b55f7eea300e0454653636fb6a1leynos/shared-actions/.github/actions/macos-package@7f4cc57326d14b55f7eea300e0454653636fb6a1targetandbin-name(noversioninput)CI Workflow (Other files)
.github/workflows/ci.yml, updated action SHAs:7f4cc57326d14b55f7eea300e0454653636fb6a17f4cc57326d14b55f7eea300e0454653636fb6a17f4cc57326d14b55f7eea300e0454653636fb6a1.github/workflows/netsukefile-test.yml, updated Setup Rust action to7f4cc57326d14b55f7eea300e0454653636fb6a1Release workflow
.github/workflows/release.yml, updated SHAs for release-related actions:7f4cc57326d14b55f7eea300e0454653636fb6a17f4cc57326d14b55f7eea300e0454653636fb6a17f4cc57326d14b55f7eea300e0454653636fb6a17f4cc57326d14b55f7eea300e0454653636fb6a1Other affected files
.github/workflows/ci.yml.github/workflows/netsukefile-test.yml.github/workflows/build-and-package.yml.github/workflows/release.ymlRationale
versioninput was not defined in workflow inputs and caused failures on macOS runners. Updating to newer SHAs across CI actions standardizes behavior and stabilizes packaging across platforms. If a version is required later, it can be derived from tags/commit or re-added with a defined input.Testing
Notes
🌿 Generated by Terry
ℹ️ Tag @terragon-labs to ask questions and address PR feedback
📎 Task: https://www.terragonlabs.com/task/b250b875-ee37-44cd-bfc6-6a4b7f1b85f5