Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 126 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ cap-std = { version = "3.4.4", features = ["fs_utf8"] }
camino = "1.2.0"
semver = { version = "1", features = ["serde"] }
anyhow = "1"
indicatif = "0.18.4"
thiserror = "1"
miette = { version = "7.6.0", features = ["fancy"] }
digest = "0.10"
Expand Down
3 changes: 3 additions & 0 deletions docs/execplans/3-8-1-add-accessible-output-mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ Implementation complete. All quality gates pass (`make check-fmt`,
`make lint`, `make test`).

**What went well:**

- The `resolve_with` dependency-injection pattern for environment variable
lookup made both unit tests and BDD tests clean and deterministic.
- The `OutputMode` enum and `StatusReporter` trait provide a clean
Expand All @@ -179,13 +180,15 @@ Implementation complete. All quality gates pass (`make check-fmt`,
worked well with checkpoint validation between stages.

**What was surprising:**

- `clippy::print_stderr` is denied globally, requiring `writeln!(io::stderr())`
instead of `eprintln!`. The `drop()` wrapper follows the `main.rs` pattern.
- The BDD `Given the environment variable` step already existed in
`manifest/mod.rs` and sets real process env vars. Using "simulated"
env vars in the TestWorld avoided test interference.

**Metrics:**

- 4 new files created, 10 files modified.
- 12 unit tests (output_mode), 7 BDD scenarios (accessible_output).
- ~300 net new lines of code (well within the 800-line tolerance).
Expand Down
Loading
Loading