Implement semver validation for manifest version

docs/behavioural-testing-in-rust-with-cucumber.md

@@ -1166,7 +1166,7 @@ aligned with what is needed.
 
 [^31]: Cucumber in cucumber – Rust – [Docs.rs](http://Docs.rs) — accessed on 14
        July 2025 —
-    <https://docs.rs/cucumber/latest/cucumber/struct.Cucumber.html>
+       <https://docs.rs/cucumber/latest/cucumber/struct.Cucumber.html>
 
 [^32]: CLI (command-line interface) - Cucumber Rust Book, accessed on
     14 July 2025, <https://cucumber-rs.github.io/cucumber/main/cli.html>

docs/netsuke-design.md

@@ -403,7 +403,7 @@ deserialization and easy debugging.
 
 Rust
 
-````rust
+```rust
 // In src/ast.rs
 
 use serde::Deserialize;
@@ -551,7 +551,7 @@ targets:
   - name: my_app
     sources: "{{ glob('src/*.c') }}"
     rule: compile
-````
+```
 
 The value of `sources`, `{{ glob('src/*.c') }}`, is not a valid YAML string
 from the perspective of a strict parser. Attempting to deserialize this
@@ -587,9 +587,10 @@ interference, ensuring a robust and predictable ingestion pipeline.
 The AST structures are implemented in `src/ast.rs` and derive `Deserialize`.
 Unknown fields are rejected to surface user errors early. `StringOrList`
 provides a default `Empty` variant, so optional lists are trivial to represent.
-The manifest version is parsed using the `semver` crate to validate that it
-follows semantic versioning rules. Global and target variable maps now share
-the `HashMap<String, String>` type for consistency. This keeps YAML manifests
+The manifest version is parsed into a `semver::Version`. Using the library's
+`Deserialize` implementation ensures any manifest with an invalid SemVer string
+fails to load. Global and target variable maps now share the
+`HashMap<String, String>` type for consistency. This keeps YAML manifests
 concise while ensuring forward compatibility.
 
 ### 3.5 Testing
@@ -1000,14 +1001,14 @@ structures to the Ninja file syntax.
 
    Code snippet
 
-   ````ninja
+   ```ninja
    # Generated from an ir::Action
    rule cc command = gcc -c -o $out $in description = CC $out depfile = $out.d
    deps = gcc
 
    ```ninja
 
-   ````
+   ```
 
 3. **Write Build Edges:** Iterate through the `graph.targets` map. For each
    `ir::BuildEdge`, write a corresponding Ninja `build` statement. This

docs/roadmap.md

@@ -24,8 +24,8 @@ compilation pipeline from parsing to execution.
     #[serde(deny_unknown_fields)]
     to enable serde_yml parsing. *(done)*
 
-  - [ ] Implement parsing for the netsuke_version field and validate it using
-    the semver crate.
+  - [x] Implement parsing for the netsuke_version field and validate it using
+    the semver crate. *(done)*
 
   - [ ] Support `phony` and `always` boolean flags on targets.
 

examples/basic_c.yml

@@ -1,4 +1,4 @@
-netsuke_version: "1.0"
+netsuke_version: "1.0.0"
 
 vars:
   cc: "{{ env('CC') | default('gcc') }}"

examples/photo_edit.yml

@@ -1,4 +1,4 @@
-netsuke_version: "1.0"
+netsuke_version: "1.0.0"
 
 vars:
   raw_dir: raw_photos

examples/visual_design.yml

@@ -1,4 +1,4 @@
-netsuke_version: "1.0"
+netsuke_version: "1.0.0"
 
 vars:
   src_dir: design/svg

examples/website.yml

@@ -1,4 +1,4 @@
-netsuke_version: "1.0"
+netsuke_version: "1.0.0"
 
 vars:
   pages_dir: pages

examples/writing.yml

@@ -1,4 +1,4 @@
-netsuke_version: "1.0"
+netsuke_version: "1.0.0"
 
 vars:
   chapters_dir: chapters

tests/ast_tests.rs

@@ -213,3 +213,9 @@ fn invalid_enum_variants() {
     "#;
     assert!(serde_yml::from_str::<NetsukeManifest>(yaml).is_err());
 }
+
+#[test]
+fn invalid_manifest_version() {
+    let yaml = "netsuke_version: '1.0'";
+    assert!(serde_yml::from_str::<NetsukeManifest>(yaml).is_err());
+}

tests/data/invalid_version.yml

@@ -0,0 +1,6 @@
+netsuke_version: "1.0"
+targets:
+  - name: invalid
+    recipe:
+      kind: command
+      command: "echo invalid"

tests/features/manifest.feature

@@ -4,3 +4,8 @@ Feature: Manifest parsing
     When the manifest file "tests/data/minimal.yml" is parsed
     Then the manifest version is "1.0.0"
     And the first target name is "hello"
+
+  Scenario: Invalid manifest version
+    When the manifest file "tests/data/invalid_version.yml" is parsed
+    Then manifest parsing should fail
+    And the manifest error message should contain "version"

tests/steps/manifest_steps.rs

@@ -54,3 +54,19 @@ fn first_target_name(world: &mut CliWorld, name: String) {
         other => panic!("Expected StringOrList::String, got: {other:?}"),
     }
 }
+
+#[then("manifest parsing should fail")]
+fn manifest_parsing_should_fail(world: &mut CliWorld) {
+    assert!(world.manifest.is_none(), "expected parsing to fail");
+    assert!(world.manifest_error.is_some(), "error message missing");
+}
+
+#[expect(
+    clippy::needless_pass_by_value,
+    reason = "Cucumber requires owned String arguments"
+)]
+#[then(expr = "the manifest error message should contain {string}")]
+fn manifest_error_contains(world: &mut CliWorld, text: String) {
+    let err = world.manifest_error.as_ref().expect("error");
+    assert!(err.contains(&text), "{err} does not contain {text}");
+}