-
Notifications
You must be signed in to change notification settings - Fork 0
Add verbose logging via tracing #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8745820
69ed1ff
8be56b9
aeaf109
16bcad5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |||||||||||||||
| //! ``` | ||||||||||||||||
|
|
||||||||||||||||
| use semver::Version; | ||||||||||||||||
| use serde::{Deserialize, de::Deserializer}; | ||||||||||||||||
| use serde::{Deserialize, Serialize, de::Deserializer}; | ||||||||||||||||
|
|
||||||||||||||||
| fn deserialize_actions<'de, D>(deserializer: D) -> Result<Vec<Target>, D::Error> | ||||||||||||||||
| where | ||||||||||||||||
|
|
@@ -53,7 +53,7 @@ | |||||||||||||||
| /// assert_eq!(manifest.targets.len(), 1); | ||||||||||||||||
| /// # Ok(()) } | ||||||||||||||||
| /// ``` | ||||||||||||||||
| #[derive(Debug, Deserialize)] | ||||||||||||||||
| #[derive(Debug, Deserialize, Serialize)] | ||||||||||||||||
| #[serde(deny_unknown_fields)] | ||||||||||||||||
|
Comment on lines
+56
to
57
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix build: implement
@@
#[derive(Debug, Clone, PartialEq)]
-pub enum Recipe {
+#[derive(Debug, Clone, PartialEq, Serialize)]
+#[serde(untagged)]
+pub enum Recipe {Failing to do this blocks compilation and the CI pipeline. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| pub struct NetsukeManifest { | ||||||||||||||||
| /// Semantic version of the manifest format. | ||||||||||||||||
|
|
@@ -86,7 +86,7 @@ | |||||||||||||||
| /// targets. It may define a command line, a script block, or delegate to another | ||||||||||||||||
| /// named rule. Dependencies may be specified as either a single string or a | ||||||||||||||||
| /// list of strings. | ||||||||||||||||
| #[derive(Debug, Deserialize)] | ||||||||||||||||
| #[derive(Debug, Deserialize, Serialize)] | ||||||||||||||||
|
Check failure on line 89 in src/ast.rs
|
||||||||||||||||
| #[serde(deny_unknown_fields)] | ||||||||||||||||
| pub struct Rule { | ||||||||||||||||
| /// Unique identifier used by targets to reference this rule. | ||||||||||||||||
|
|
@@ -164,7 +164,7 @@ | |||||||||||||||
| /// Targets describe the files produced by a rule and their dependencies. | ||||||||||||||||
| /// `phony` targets are always considered out of date, while `always` targets are | ||||||||||||||||
| /// regenerated even if their inputs are unchanged. | ||||||||||||||||
| #[derive(Debug, Deserialize)] | ||||||||||||||||
| #[derive(Debug, Deserialize, Serialize)] | ||||||||||||||||
|
Check failure on line 167 in src/ast.rs
|
||||||||||||||||
| #[serde(deny_unknown_fields)] | ||||||||||||||||
| pub struct Target { | ||||||||||||||||
| /// Output file or files. | ||||||||||||||||
|
|
@@ -212,7 +212,7 @@ | |||||||||||||||
| /// - hello | ||||||||||||||||
| /// - world | ||||||||||||||||
| /// ``` | ||||||||||||||||
| #[derive(Debug, Deserialize, Default, Clone, PartialEq)] | ||||||||||||||||
| #[derive(Debug, Deserialize, Serialize, Default, Clone, PartialEq)] | ||||||||||||||||
| #[serde(untagged)] | ||||||||||||||||
| pub enum StringOrList { | ||||||||||||||||
| /// No value provided. | ||||||||||||||||
|
|
||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Clarify
--verboseflag behaviour within the prose sectionsAdd one or two sentences in Section 8.3 (Command Behaviour) explaining exactly what enabling
-v/--verbosedoes at runtime: initialises atracing_subscriber, raises the global log level toDEBUG, and emits the extra diagnostics listed in the PR (AST dump, Ninja path, Ninja invocation). This keeps the narrative part of the design document in sync with the updated code snippet.🤖 Prompt for AI Agents