Merged
Conversation
Contributor
Reviewer's GuideThis PR enriches the GitHub Actions netsukefile-test workflow by replacing the single generated.txt target with multiple dependent and inline targets, adding action definitions (including an unused action), and updating build and assertion steps to validate both file outputs and action behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Warning Rate limit exceeded@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughExpand the GitHub Actions workflow for Netsukefile testing by defining multiple build targets, adding new actions, and updating build and assertion steps to handle these targets. Modify the heredoc delimiter in the workflow configuration. No changes were made to exported or public entities. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant Netsukefile
participant FileSystem
Workflow->>Netsukefile: Define targets (base.txt, dependent.txt, inline-command.txt, inline-script.txt)
Workflow->>Netsukefile: Add actions (say-hello, unused-action)
Workflow->>Netsukefile: Build multiple targets
Netsukefile->>FileSystem: Create/modify files per target definitions
Workflow->>FileSystem: Assert existence of generated files
Workflow->>Netsukefile: Build say-hello action target
Workflow->>FileSystem: Assert say-hello artifact exists
Workflow->>FileSystem: Assert unused-action artifact does not exist
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+53
to
+68
| - name: Build dependent and inline targets | ||
| run: ./target/debug/netsuke --verbose build dependent.txt inline-command.txt inline-script.txt | ||
| - name: Assert dependent artefacts exist | ||
| run: | | ||
| scripts/assert-file-exists.sh base.txt | ||
| scripts/assert-file-exists.sh dependent.txt | ||
| - name: Assert inline command artefact exists | ||
| run: scripts/assert-file-exists.sh inline-command.txt | ||
| - name: Assert inline script artefact exists | ||
| run: scripts/assert-file-exists.sh inline-script.txt | ||
| - name: Run action target | ||
| run: ./target/debug/netsuke --verbose build say-hello | ||
| - name: Assert action artefact exists | ||
| run: scripts/assert-file-exists.sh action-called.txt | ||
| - name: Assert unused action artefact absent | ||
| run: test ! -f unused.txt |
Contributor
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Group all build targets in a single Netsuke invocation to cut CI time
You launch Netsuke twice: once for the three inline/dependency targets and once for say-hello.
Building everything in one call avoids the second binary start-up, re-parsing of the manifest and cache lookup, shaving a few seconds off each run.
- - name: Build dependent and inline targets
- run: ./target/debug/netsuke --verbose build dependent.txt inline-command.txt inline-script.txt
+ - name: Build all required targets
+ run: ./target/debug/netsuke --verbose build \
+ dependent.txt inline-command.txt inline-script.txt say-hello
...
- - name: Run action target
- run: ./target/debug/netsuke --verbose build say-hello
+ # call above already builds say-hello📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Build dependent and inline targets | |
| run: ./target/debug/netsuke --verbose build dependent.txt inline-command.txt inline-script.txt | |
| - name: Assert dependent artefacts exist | |
| run: | | |
| scripts/assert-file-exists.sh base.txt | |
| scripts/assert-file-exists.sh dependent.txt | |
| - name: Assert inline command artefact exists | |
| run: scripts/assert-file-exists.sh inline-command.txt | |
| - name: Assert inline script artefact exists | |
| run: scripts/assert-file-exists.sh inline-script.txt | |
| - name: Run action target | |
| run: ./target/debug/netsuke --verbose build say-hello | |
| - name: Assert action artefact exists | |
| run: scripts/assert-file-exists.sh action-called.txt | |
| - name: Assert unused action artefact absent | |
| run: test ! -f unused.txt | |
| - name: Build all required targets | |
| run: ./target/debug/netsuke --verbose build \ | |
| dependent.txt inline-command.txt inline-script.txt say-hello | |
| - name: Assert dependent artefacts exist | |
| run: | | |
| scripts/assert-file-exists.sh base.txt | |
| scripts/assert-file-exists.sh dependent.txt | |
| - name: Assert inline command artefact exists | |
| run: scripts/assert-file-exists.sh inline-command.txt | |
| - name: Assert inline script artefact exists | |
| run: scripts/assert-file-exists.sh inline-script.txt | |
| # call above already builds say-hello | |
| - name: Assert action artefact exists | |
| run: scripts/assert-file-exists.sh action-called.txt | |
| - name: Assert unused action artefact absent | |
| run: test ! -f unused.txt |
🤖 Prompt for AI Agents
In .github/workflows/netsukefile-test.yml around lines 53 to 68, the workflow
runs the Netsuke build command twice separately for different targets, causing
unnecessary overhead. To fix this, combine all build targets (dependent.txt,
inline-command.txt, inline-script.txt, and say-hello) into a single Netsuke
invocation by listing them all in one command line. This reduces CI time by
avoiding multiple binary startups and repeated manifest parsing.
leynos
force-pushed
the
codex/extend-netsukefile-test.yml-with-scenarios
branch
from
689c8df to
ba16f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make fmtmake lintmake testhttps://chatgpt.com/codex/tasks/task_e_68924c851c088322b4d0e9e412d6d360
Summary by Sourcery
Extend the netsukefile-test GitHub Actions workflow to cover dependent targets, inline commands, inline scripts, and CLI-run actions, and to assert artifact creation and skipping of unused actions.
CI: