Skip to content

Clean workflow cache before build #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leynos merged 1 commit into from
Aug 7, 2025
+2 −0
Merged

Clean workflow cache before build #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/netsukefile-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-
- name: Clean build artefacts
run: make clean
- name: Build Netsuke
Comment on lines +29 to 31
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Delete target from the cache or skip make clean to avoid wasting CI time

make clean obliterates the very target directory that was just restored by the cache action (Lines 20-26). This negates any compile-time win and costs extra bandwidth when the cache is re-uploaded at the end of the job. Either:

  1. Keep the cleaning step but stop caching target, or
  2. Keep caching target and drop the cleaning step, relying on incremental compilation.

Pick one to keep the workflow lean.

@@
           ~/.cargo/git
-          target

🏁 Script executed:

#!/bin/bash
set -e
sed -n '1,50p' .github/workflows/netsukefile-test.yml

Length of output: 1556

Streamline CI cache usage
Delete target from the cached paths or drop the make clean step. The make clean invocation wipes out the restored target directory, negating any cache benefit and forcing a full rebuild and re-upload.

Possible fixes:

  • Remove target from the cache paths 
      with:
    path: |
      ~/.cargo/registry
      ~/.cargo/git
-     target
  • Or remove the clean step entirely 
    -    - name: Clean build artefacts
-      run: make clean
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Clean build artefacts
run: make clean
- name: Build Netsuke
- - name: Clean build artefacts
- run: make clean
- name: Build Netsuke
🤖 Prompt for AI Agents 
In .github/workflows/netsukefile-test.yml around lines 29 to 31, the `make
clean` step removes the `target` directory that is restored from cache, negating
caching benefits. To fix this, either remove `target` from the cache paths so it
is not restored and then deleted, or remove the `make clean` step entirely to
preserve the cached `target` directory and speed up builds.

run: make build
- name: Create Netsukefile
Expand Down
Loading