-
Notifications
You must be signed in to change notification settings - Fork 0
Create parent dirs for Ninja file #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leynos
merged 13 commits into
main
from
codex/ensure-parent-directories-exist-when-writing-ninja-file
Aug 11, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4ca3cff
Create parent dirs for Ninja file
leynos 50126c8
Scope env vars in tests
leynos ad35a17
Inject env for ninja path
leynos 22ce15f
Skip empty Ninja parents and detect .exe paths
leynos dbeda1f
Search PATHEXT when locating executables
leynos e4855b0
Add serial_test for test isolation and update dependencies
leynos f433ebf
Clarifies guidance on mocking non-deterministic dependencies
leynos 6722457
Refactors test setup using rstest fixtures for isolation
leynos 9d1107a
Clarifies docstring formatting for return values
leynos 0243530
Exposes internal helpers for doctests via public module
leynos 2217258
Refactors mock PATH setup to enforce UTF-8 and explicit errors
leynos c28ce1e
Replace PATH cleanup closures with a RAII guard
leynos 6d51ef8
Apply formatting
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Documentation addition aligns with testing strategy — add lint/run notes
The guidance to mock environment and clock via the mockable crate aligns with the new test scaffolding. Append an explicit reminder under “Markdown Guidance” to run make markdownlint and make fmt after editing docs; the CI note mentioned MD040 on this file.
🤖 Prompt for AI Agents