Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ project:
- Use `rstest` fixtures for shared setup.
- Replace duplicated tests with `#[rstest(...)]` parameterised cases.
- Prefer `mockall` for mocks/stubs.
- Mock non-deterministic dependencies (e.g., environment variables and the
system clock) using dependency injection with the `mockable` crate (traits
like `Env` and `Clock`) where appropriate. See
`docs/reliable-testing-in-rust-via-dependency-injection.md` for guidance.
Comment on lines +148 to +151
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Documentation addition aligns with testing strategy — add lint/run notes

The guidance to mock environment and clock via the mockable crate aligns with the new test scaffolding. Append an explicit reminder under “Markdown Guidance” to run make markdownlint and make fmt after editing docs; the CI note mentioned MD040 on this file.

🤖 Prompt for AI Agents
In AGENTS.md around lines 148 to 151, append an explicit reminder under the
“Markdown Guidance” section instructing editors to run `make markdownlint` and
`make fmt` after editing docs (and note the CI MD040 lint that flagged this
file); add one short sentence such as “After editing documentation run `make
markdownlint` and `make fmt` to satisfy CI (see MD040).” and commit the updated
markdown.

- Prefer `.expect()` over `.unwrap()`.
- Use `concat!()` to combine long string literals rather than escaping newlines
with a backslash.
Expand Down
156 changes: 132 additions & 24 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ rstest = "0.18.0"
cucumber = "0.20.0"
tokio = { version = "1", features = ["macros", "rt-multi-thread"], default-features = false }
insta = { version = "1", features = ["yaml"] }
serial_test = "3"
assert_cmd = "2.0.17"
mockable = { version = "0.3", features = ["mock"] }
serial_test = "3"
Comment thread
leynos marked this conversation as resolved.

[[test]]
name = "cucumber"
Expand Down
Loading
Loading