Skip to content

Fix setup-rust manifest#32

Merged
leynos merged 2 commits intomainfrom
codex/fix-setup-rust-action-errors
Jul 26, 2025
Merged

Fix setup-rust manifest#32
leynos merged 2 commits intomainfrom
codex/fix-setup-rust-action-errors

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Jul 26, 2025

Summary

  • add explicit shells for run steps in setup-rust composite action

Testing

  • pytest -q

https://chatgpt.com/codex/tasks/task_e_6884e8f34c8c8322be6c27e7f2e4531c

Summary by Sourcery

Enhancements:

  • Add explicit shell: bash to nightly toolchain, macOS target installation, and OpenBSD-related run steps in the setup-rust action

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jul 26, 2025

Reviewer's Guide

This PR updates the setup-rust composite action manifest by normalizing step indentation and adding explicit shell directives to every run step to ensure consistent execution environments.

File-Level Changes

Change Details Files
Added explicit shell declarations to run steps
  • Specified shell: bash for nightly OpenBSD toolchain installation
  • Added shell: bash to macOS target installation step
  • Included shell: bash on OpenBSD stdlib copy step
  • Declared shell: bash for adding the OpenBSD target
.github/actions/setup-rust/action.yml
Normalized YAML indentation for composite action steps
  • Converted mixed spaces to consistent two-space indentation for all steps
  • Aligned dash markers and nested keys under runs.steps for clarity
.github/actions/setup-rust/action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 26, 2025

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions configuration to explicitly specify the Bash shell for improved clarity and consistency.
    • Normalised indentation for better readability in workflow files.

Walkthrough

Specify the Bash shell explicitly for several run steps in the .github/actions/setup-rust/action.yml composite action. Adjust indentation throughout the file from six to four spaces to standardise YAML formatting. Do not alter any logic, conditions, or executed commands in the action.

Changes

File Change Summary
.github/actions/setup-rust/action.yml Add shell: bash to multiple run steps; normalise indentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

In YAML’s embrace, the spaces align,
Four per indent, now looking divine.
Bash leads the way for every command,
Consistency reigns, just as we planned.
Actions now clearer, no more a muddle—
The pipeline proceeds, free from a fuddle!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 175d149 and b784292.

📒 Files selected for processing (1)
  • .github/actions/setup-rust/action.yml (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/actions/*/action.yml

📄 CodeRabbit Inference Engine (AGENTS.md)

.github/actions/*/action.yml: Each action must have an action.yml file containing every input and output, with required ones clearly marked.
Composite actions referencing sibling scripts must use ${{ github.action_path }} for portability.

Files:

  • .github/actions/setup-rust/action.yml
🔇 Additional comments (4)
.github/actions/setup-rust/action.yml (4)

49-57: Keep the explicit bash shell directive – improves determinism.

Declaring shell: bash removes any doubt about which interpreter runs this cross-compilation bootstrap on Linux, especially inside composite actions where self-hosted runners could default differently.


73-75: Retain the bash shell directive for apt-based dependency installation.

Explicitly pinning the shell aligns this step with the others and avoids surprises on custom runners that might default to dash or another POSIX shell lacking set -euo pipefail semantics.


98-105: Good call adding shell: bash to the macOS target installation step.

The step now mirrors the other Linux-only commands, ensuring a uniform environment whenever cross-compilation targets are installed.


123-127: Maintain bash for the OpenBSD stdlib copy and target addition steps.

These commands rely on $NIGHTLY_SYSROOT expansion and brace-style variables; locking the interpreter to bash prevents portability regressions.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-setup-rust-action-errors

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leynos leynos merged commit c630851 into main Jul 26, 2025
1 check was pending
@leynos leynos deleted the codex/fix-setup-rust-action-errors branch July 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant