Conversation
Reviewer's GuideEnable Windows support in the setup-rust action for installing PostgreSQL client libraries via Chocolatey, adjust conditional logic in action.yml, and update README and CHANGELOG accordingly. Flow diagram for OS-specific PostgreSQL dependency installation in setup-rust actionflowchart TD
Start([Start])
CheckDeps{install-postgres-deps == true?}
OSCheck{Runner OS}
LinuxInstall[Install libpq-dev via apt]
WinInstall[Install postgresql17 via Chocolatey]
SetEnv[Set PG_INCLUDE, PG_LIB, update PATH]
End([End])
Start --> CheckDeps
CheckDeps -- No --> End
CheckDeps -- Yes --> OSCheck
OSCheck -- Linux --> LinuxInstall --> End
OSCheck -- Windows --> WinInstall --> SetEnv --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update enhances the Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant SetupRustAction
participant OS_PackageManager
Workflow->>SetupRustAction: Run with install-postgres-deps=true
alt On Linux
SetupRustAction->>OS_PackageManager: Install libpq-dev via apt-get
else On Windows
SetupRustAction->>OS_PackageManager: Install postgresql17 via Chocolatey
SetupRustAction->>SetupRustAction: Set PG_INCLUDE, PG_LIB, update PATH
end
SetupRustAction-->>Workflow: PostgreSQL client libraries installed
Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/actions/setup-rust/README.md:25` </location>
<code_context>
install-postgres-deps: true
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries using the package manager of the underlying runner. On Linux this is
+`apt` (`libpq-dev`), while on Windows Chocolatey is used to install the
</code_context>
<issue_to_address>
This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
</issue_to_address>
### Comment 2
<location> `.github/actions/setup-rust/README.md:26` </location>
<code_context>
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries using the package manager of the underlying runner. On Linux this is
+`apt` (`libpq-dev`), while on Windows Chocolatey is used to install the
+`postgresql17` package and expose its headers and import libraries via
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column limit.
Ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
</issue_to_address>
### Comment 3
<location> `.github/actions/setup-rust/README.md:27` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries using the package manager of the underlying runner. On Linux this is
+`apt` (`libpq-dev`), while on Windows Chocolatey is used to install the
+`postgresql17` package and expose its headers and import libraries via
+`PG_INCLUDE` and `PG_LIB` environment variables.
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>
### Comment 4
<location> `.github/actions/setup-rust/README.md:28` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries using the package manager of the underlying runner. On Linux this is
+`apt` (`libpq-dev`), while on Windows Chocolatey is used to install the
+`postgresql17` package and expose its headers and import libraries via
+`PG_INCLUDE` and `PG_LIB` environment variables.
+
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>
### Comment 5
<location> `.github/actions/setup-rust/README.md:29` </location>
<code_context>
+libraries using the package manager of the underlying runner. On Linux this is
+`apt` (`libpq-dev`), while on Windows Chocolatey is used to install the
+`postgresql17` package and expose its headers and import libraries via
+`PG_INCLUDE` and `PG_LIB` environment variables.
+
## Caching
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install-postgres-deps: true | ||
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client |
There was a problem hiding this comment.
issue (review_instructions): This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries using the package manager of the underlying runner. On Linux this is |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column limit.
Ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries using the package manager of the underlying runner. On Linux this is | ||
| `apt` (`libpq-dev`), while on Windows Chocolatey is used to install the |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries using the package manager of the underlying runner. On Linux this is | ||
| `apt` (`libpq-dev`), while on Windows Chocolatey is used to install the | ||
| `postgresql17` package and expose its headers and import libraries via |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| libraries using the package manager of the underlying runner. On Linux this is | ||
| `apt` (`libpq-dev`), while on Windows Chocolatey is used to install the | ||
| `postgresql17` package and expose its headers and import libraries via | ||
| `PG_INCLUDE` and `PG_LIB` environment variables. |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.github/actions/setup-rust/CHANGELOG.md(1 hunks).github/actions/setup-rust/README.md(1 hunks).github/actions/setup-rust/action.yml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.github/actions/setup-rust/README.md
[typographical] ~26-~26: The word ‘When’ starts a question. Add a question mark (“?”) at the end of the sentence.
Context: ...package manager of the underlying runner. On Linux this is apt (libpq-dev), w...
(WRB_QUESTION_MARK)
[typographical] ~26-~26: It is considered good style to insert a comma after introductory phrases with dates or proper nouns.
Context: ...ge manager of the underlying runner. On Linux this is apt (libpq-dev), while on W...
(IN_NNP_COMMA)
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...x this is apt (libpq-dev), while on Windows Chocolatey is used to install the `post...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (2)
.github/actions/setup-rust/action.yml (1)
39-43: Environment variables are correctly exposed for subsequent stepsWriting
PG_INCLUDEandPG_LIBto$GITHUB_ENVand appending the binary path to$GITHUB_PATHensures headers, libraries and executables are available to later steps. This follows GitHub Actions conventions..github/actions/setup-rust/CHANGELOG.md (1)
4-7: Changelog entry for v1.0.3 is clearThe new entry accurately describes the addition of Windows PostgreSQL client library installation via Chocolatey.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/actions/setup-rust/README.md(1 hunks).github/actions/setup-rust/action.yml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.github/actions/setup-rust/README.md
[typographical] ~26-~26: The word ‘When’ starts a question. Add a question mark (“?”) at the end of the sentence.
Context: ...ia the package manager for the runner OS. On Linux, it uses apt (libpq-dev). ...
(WRB_QUESTION_MARK)
🔇 Additional comments (2)
.github/actions/setup-rust/README.md (1)
25-29: Documentation update is clear and adheres to style guidelinesThe new paragraph correctly describes OS-specific installation, uses proper punctuation and stays within 80 columns.
.github/actions/setup-rust/action.yml (1)
27-27: Linux install step conditional is correctly expressedThe
ifuses explicit string comparison and expression syntax to gate thelibpq-devinstallation on Linux.
|
@sourcery-ai review |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/actions/setup-rust/README.md:25` </location>
<code_context>
install-postgres-deps: true
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
</code_context>
<issue_to_address>
This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
</issue_to_address>
### Comment 2
<location> `.github/actions/setup-rust/README.md:26` </location>
<code_context>
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
</code_context>
<issue_to_address>
This line is part of a paragraph that is not wrapped to 80 columns.
Ensure that all lines in paragraphs and bullet points are wrapped to 80 columns for readability and consistency.
</issue_to_address>
### Comment 3
<location> `.github/actions/setup-rust/README.md:27` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
</code_context>
<issue_to_address>
This line is part of a paragraph that is not wrapped to 80 columns.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>
### Comment 4
<location> `.github/actions/setup-rust/README.md:28` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
</code_context>
<issue_to_address>
This line is part of a paragraph that is not wrapped to 80 columns.
All lines in paragraphs should be wrapped to 80 columns. Please update this section accordingly.
</issue_to_address>
### Comment 5
<location> `.github/actions/setup-rust/README.md:29` </location>
<code_context>
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
## Caching
</code_context>
<issue_to_address>
This line is part of a paragraph that is not wrapped to 80 columns.
Please ensure the entire paragraph is wrapped to 80 columns, including this line.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install-postgres-deps: true | ||
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client |
There was a problem hiding this comment.
issue (review_instructions): This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that is not wrapped to 80 columns.
Ensure that all lines in paragraphs and bullet points are wrapped to 80 columns for readability and consistency.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that is not wrapped to 80 columns.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that is not wrapped to 80 columns.
All lines in paragraphs should be wrapped to 80 columns. Please update this section accordingly.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and | ||
| `PG_LIB` environment variables. |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that is not wrapped to 80 columns.
Please ensure the entire paragraph is wrapped to 80 columns, including this line.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/actions/setup-rust/README.md:25` </location>
<code_context>
install-postgres-deps: true
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
</code_context>
<issue_to_address>
This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
</issue_to_address>
### Comment 2
<location> `.github/actions/setup-rust/README.md:27` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column limit.
Please ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
</issue_to_address>
### Comment 3
<location> `.github/actions/setup-rust/README.md:28` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>
### Comment 4
<location> `.github/actions/setup-rust/README.md:29` </location>
<code_context>
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
## Caching
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install-postgres-deps: true | ||
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client |
There was a problem hiding this comment.
issue (review_instructions): This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide for Markdown files.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column limit.
Please ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and | ||
| `PG_LIB` environment variables. |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column limit.
Please wrap this paragraph to 80 columns as required by the Markdown formatting guidelines.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/actions/setup-rust/README.md:25` </location>
<code_context>
install-postgres-deps: true
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
</code_context>
<issue_to_address>
This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide.
</issue_to_address>
### Comment 2
<location> `.github/actions/setup-rust/README.md:26` </location>
<code_context>
```
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column limit.
Ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
</issue_to_address>
### Comment 3
<location> `.github/actions/setup-rust/README.md:27` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the instructions.
</issue_to_address>
### Comment 4
<location> `.github/actions/setup-rust/README.md:28` </location>
<code_context>
+When `install-postgres-deps` is enabled, the action installs PostgreSQL client
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please ensure all lines in this paragraph are wrapped to 80 columns or fewer.
</issue_to_address>
### Comment 5
<location> `.github/actions/setup-rust/README.md:29` </location>
<code_context>
+libraries via the package manager for the runner OS. On Linux, it uses
+`apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17`
+and exposes its headers and import libraries via `PG_INCLUDE` and
+`PG_LIB` environment variables.
+
## Caching
</code_context>
<issue_to_address>
This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as per the review instructions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install-postgres-deps: true | ||
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client |
There was a problem hiding this comment.
issue (review_instructions): This paragraph exceeds the 80 column wrapping limit for Markdown text.
Please wrap this paragraph so that no line exceeds 80 columns, as per the style guide.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| ``` | ||
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column limit.
Ensure all lines in paragraphs and bullet points are wrapped to 80 columns or fewer.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
|
|
||
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as required by the instructions.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| When `install-postgres-deps` is enabled, the action installs PostgreSQL client | ||
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please ensure all lines in this paragraph are wrapped to 80 columns or fewer.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
| libraries via the package manager for the runner OS. On Linux, it uses | ||
| `apt` (`libpq-dev`). On Windows, Chocolatey installs `postgresql17` | ||
| and exposes its headers and import libraries via `PG_INCLUDE` and | ||
| `PG_LIB` environment variables. |
There was a problem hiding this comment.
issue (review_instructions): This line is part of a paragraph that exceeds the 80 column wrapping limit.
Please wrap this paragraph to 80 columns as per the review instructions.
Review instructions:
Path patterns: **/*.md
Instructions:
Paragraphs and bullets must be wrapped to 80 columns
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/actions/setup-rust/action.yml(1 hunks)
🔇 Additional comments (3)
.github/actions/setup-rust/action.yml (3)
27-27: Approve Linux installation condition.The
ifexpression now correctly uses explicit string comparison and the composite expression syntax:
${{ inputs.install-postgres-deps == 'true' && runner.os == 'Linux' }}.
30-33: Approve Windows step header.The Windows-specific step correctly gates on
${{ inputs.install-postgres-deps == 'true' && runner.os == 'Windows' }}
and usesshell: pwshto target PowerShell Core.
34-35: Approve Chocolatey install command.The single-line
choco install postgresql17 --no-progress -y --params '/Password:postgres /NoService /SkipStackBuilder'
avoids invalid backslashes for continuation and suppresses the server bits as intended.
| # Tell the rest of the job where the headers and import library are | ||
| $pgRoot = "${Env:ProgramFiles}\PostgreSQL\17" | ||
| echo "PG_INCLUDE=$pgRoot\include" >> $Env:GITHUB_ENV | ||
| echo "PG_LIB=$pgRoot\lib" >> $Env:GITHUB_ENV | ||
| echo "$pgRoot\bin" | Out-File -FilePath $Env:GITHUB_PATH -Encoding utf8 -Append |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consistent environment file writes.
To avoid potential encoding mismatches or BOM artifacts, unify the approach by using Out-File with -Encoding utf8 -Append for all GITHUB_ENV entries. For example:
- echo "PG_INCLUDE=$pgRoot\include" >> $Env:GITHUB_ENV
- echo "PG_LIB=$pgRoot\lib" >> $Env:GITHUB_ENV
+ "PG_INCLUDE=$pgRoot\include" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
+ "PG_LIB=$pgRoot\lib" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Tell the rest of the job where the headers and import library are | |
| $pgRoot = "${Env:ProgramFiles}\PostgreSQL\17" | |
| echo "PG_INCLUDE=$pgRoot\include" >> $Env:GITHUB_ENV | |
| echo "PG_LIB=$pgRoot\lib" >> $Env:GITHUB_ENV | |
| echo "$pgRoot\bin" | Out-File -FilePath $Env:GITHUB_PATH -Encoding utf8 -Append | |
| # Tell the rest of the job where the headers and import library are | |
| $pgRoot = "${Env:ProgramFiles}\PostgreSQL\17" | |
| - echo "PG_INCLUDE=$pgRoot\include" >> $Env:GITHUB_ENV | |
| - echo "PG_LIB=$pgRoot\lib" >> $Env:GITHUB_ENV | |
| + "PG_INCLUDE=$pgRoot\include" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append | |
| + "PG_LIB=$pgRoot\lib" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append | |
| echo "$pgRoot\bin" | Out-File -FilePath $Env:GITHUB_PATH -Encoding utf8 -Append |
🤖 Prompt for AI Agents
In .github/actions/setup-rust/action.yml around lines 37 to 41, the script
writes environment variables to GITHUB_ENV using echo redirection, which can
cause encoding inconsistencies. Replace all echo redirections to GITHUB_ENV with
Out-File commands using the -Encoding utf8 -Append flags to ensure consistent
UTF-8 encoding without BOM artifacts for all environment file writes.
leynos
deleted the
codex/add-windows-postgresql-installation-to-setup-rust-action
branch
1 participant
Summary
install-postgres-depsTesting
git status --shorthttps://chatgpt.com/codex/tasks/task_e_6855621c71d8832281627e34b59301aa
Summary by Sourcery
Enable installing PostgreSQL dependencies on Windows using Chocolatey alongside existing Linux support and document the new behavior
New Features:
Enhancements:
Documentation:
Summary by CodeRabbit