Upgrade rusqlite to v0.32.1 across workspace#82
Conversation
Updated rusqlite from 0.31.0 to 0.32.1 and libsqlite3-sys from 0.28.0 to 0.30.1 across the workspace Cargo.toml files and Cargo.lock to keep dependencies up to date. Co-authored-by: devboxerhub[bot] <devboxerhub[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
SummaryThis pull request upgrades rusqlite from 0.31.0 to 0.32.1 across the workspace and centralises dependency management by moving the rusqlite dependency to workspace level in the root Cargo.toml. ChangesWorkspace-level dependency addition:
Per-crate dependency consolidation:
RationaleThe bundled feature enables Design ContextThe use of rusqlite with the bundled feature is documented in the architectural design documents ( TestingNo source code changes are required. Testing should verify:
WalkthroughMove Changes
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideWorkspace-wide upgrade of the rusqlite dependency to v0.32.1 (with bundled SQLite) and corresponding lockfile updates, without any application code changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="wildside-cli/Cargo.toml" line_range="36" />
<code_context>
rstest-bdd-macros = { workspace = true }
tempfile = "3.23.0"
-rusqlite = { version = "0.31.0", features = ["bundled"] }
+rusqlite = { version = "0.32.1", features = ["bundled"] }
[features]
</code_context>
<issue_to_address>
**suggestion:** Consider centralizing the rusqlite version in the workspace to avoid duplication across crates.
rusqlite is now duplicated with the same version in several manifests (cli, core, data, scorer). To avoid future version skew, consider moving it into `[workspace.dependencies]` in the root `Cargo.toml` and referencing it in each crate with `rusqlite = { workspace = true, features = [
Suggested implementation:
```
rusqlite = { workspace = true, features = ["bundled"] }
```
To fully implement the suggestion across the workspace you will also need to:
1. In the root `Cargo.toml`, add `rusqlite` to `[workspace.dependencies]`, for example:
```toml
[workspace.dependencies]
rusqlite = { version = "0.32.1" }
```
2. In each crate that currently specifies a direct `rusqlite` dependency (`core`, `data`, `scorer`, and any others), replace the versioned dependency with the workspace reference, preserving crate-specific features, e.g.:
```toml
# Before
rusqlite = { version = "0.32.1", features = ["bundled"] }
# After
rusqlite = { workspace = true, features = ["bundled"] }
```
This will centralize the `rusqlite` version and prevent future version skew between crates.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…explicit versions Replaced explicit rusqlite version declarations with workspace replacements in all Cargo.toml files. Added rusqlite with bundled feature to root Cargo.toml. This change centralizes rusqlite dependency management and ensures consistent versioning across workspace crates. Co-authored-by: devboxerhub[bot] <devboxerhub[bot]@users.noreply.github.com>
Summary
Changes
Testing
Notes
📎 Task: https://www.devboxer.com/task/98edc9b9-236b-4270-9e90-cff6f9e1df18