File length violation: src/server/config.rs exceeds 400-line limit

[coderabbitai]

The file src/server/config.rs is currently 440 lines long, violating the coding guideline that files must not exceed 400 lines in length.

The violation is primarily due to the large test module at the end of the file. This should be addressed by extracting the test module or decomposing the file into smaller, more focused modules.

Context:

• File: src/server/config.rs
• Current length: 440 lines
• Maximum allowed: 400 lines
• Guideline: "Files must not exceed 400 lines in length"

Backlinks:

• PR: Modularise server into config, runtime and connection modules #262
• Comment: Modularise server into config, runtime and connection modules #262 (comment)
• Issue: File length violation: src/server/config.rs exceeds 400-line limit #274

[leynos]

@coderabbitai Please suggest a fix for this issue and supply a prompt for an AI coding agent to enable it to apply the fix.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, let's examine the structure and content of the config.rs file
echo "=== File line count and basic info ==="
wc -l src/server/config.rs

echo -e "\n=== File structure overview ==="
cat src/server/config.rs | grep -n "^pub\|^fn\|^struct\|^enum\|^impl\|^mod\|^#\[cfg(test)\]" | head -20

echo -e "\n=== Test module analysis ==="
# Find the test module and count its lines
grep -n "#\[cfg(test)\]" src/server/config.rs
sed -n '/^#\[cfg(test)\]/,$p' src/server/config.rs | wc -l

echo -e "\n=== Full file content ==="
cat src/server/config.rs

Length of output: 15163

---

@leynos, I've analyzed the src/server/config.rs file and found that it's 440 lines long with a large test module of 217 lines starting at line 224. The cleanest solution is to extract the test module to a separate file, which will bring the main file down to 223 lines (well under the 400-line limit).

Fix Suggestion

Extract the test module to a separate file following Rust testing conventions:

1. Create a new test file: src/server/config/tests.rs
2. Move the entire test module (lines 224-440) to this new file
3. Update the main file to remove the test module
4. Add a module declaration in the main file or parent module

This approach:

• Reduces config.rs from 440 to 223 lines
• Follows Rust testing best practices
• Maintains all existing functionality and test coverage
• Keeps tests logically organized and easily discoverable

AI Coding Agent Prompt

You are tasked with fixing a file length violation in src/server/config.rs by extracting its test module to a separate file.

**Context:**
- File: src/server/config.rs (440 lines, exceeds 400-line limit)
- Violation: Large test module at the end of the file (lines 224-440, 217 lines)
- Goal: Extract test module to reduce main file to under 400 lines

**Required Changes:**

1. **Create new test file**: `src/server/config/tests.rs`
   - Copy the entire test module content from config.rs (lines 224-440)
   - Remove the `#[cfg(test)]` attribute and `mod tests {` wrapper
   - Keep all the test functions and their content intact
   - Ensure all imports are preserved and functional

2. **Update main config.rs file**:
   - Remove lines 224-440 (the entire test module)
   - The file should end after the `bind_std_listener` function
   - Ensure no trailing whitespace or empty lines

3. **Create module structure** (if needed):
   - If `src/server/config/` directory doesn't exist, create it
   - Move `src/server/config.rs` to `src/server/config/mod.rs`
   - Place the new tests.rs file in the config directory

4. **Verify imports in tests.rs**:
   - Ensure all necessary imports are included
   - Add `use super::*;` if needed to access parent module items
   - Verify all test utilities are properly imported

**Key Requirements:**
- Maintain all existing functionality
- Preserve all test coverage
- Follow Rust module organization conventions
- Ensure the main file is under 400 lines
- Keep imports minimal and clean

**Expected Result:**
- `src/server/config/mod.rs`: ~223 lines (main implementation)
- `src/server/config/tests.rs`: ~210 lines (extracted tests)
- All tests should continue to pass without modification

Execute these changes carefully, ensuring no functionality is lost and all tests remain operational.

The key insight is that the test module is self-contained and can be cleanly extracted without affecting the main functionality. This solution is both simple and follows Rust best practices for test organization.

🐰💭
Thoughtfully organizing code for better maintainability...