Refactor duplicated bind logic in server config implementations

[coderabbitai]

Problem

The server configuration has duplicated bind logic in both the Unbound and Bound implementations. The bind() and bind_listener() methods contain similar logic across different server states, leading to code duplication and maintenance overhead.

Suggested Solution

Refactor the duplicated bind logic into a single private helper function to reduce repetition and simplify maintenance. This would centralise the binding logic and make it easier to modify in the future.

Context

Identified during code review of PR #262: #262

Issue: #275

Files Affected

• src/server/config.rs

Related Issues

• Enforce server binding at compile time instead of runtime panics #263: Enforce server binding at compile time
• Make exponential backoff parameters configurable in accept_loop #264: Make exponential backoff parameters configurable

[leynos]

@coderabbitai Has this now been resolved in the latest commit?

Use codegraph analysis to determine your answer.

If this comment is now resolved, please mark it as such using the API. Otherwise, please provide an AI agent prompt for the remaining work to be done to address this comment.

[coderabbitai]

Issue resolved. The duplicated bind logic has been refactored into a single private helper function bind_to_listener() in src/server/config/binding.rs (lines 61-94). Both Unbound and Bound implementations now delegate to this shared helper, eliminating code duplication and simplifying maintenance as requested.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Get details about issue `#275`
echo "=== Issue `#275` Details ==="
gh issue view 275 --json title,body,state,labels,url,comments

# Get the latest commits (last 5)
echo -e "\n=== Latest Commits ==="
git log -5 --oneline --no-decorate

# Get more details about the latest commit
echo -e "\n=== Latest Commit Details ==="
git log -1 --stat

# Get the full diff of the latest commit
echo -e "\n=== Latest Commit Diff ==="
git log -1 -p

Length of output: 14542

---

🏁 Script executed:

#!/bin/bash

# Check if src/server/config.rs exists and examine the bind logic
echo "=== Checking src/server/config.rs ==="
if [ -f "src/server/config.rs" ]; then
    echo "File exists. Checking for bind methods..."
    # Look for bind-related methods
    rg -n -C5 'fn bind\(' src/server/config.rs
    echo -e "\n=== Checking for bind_listener methods ==="
    rg -n -C5 'fn bind_listener\(' src/server/config.rs
else
    echo "File src/server/config.rs not found"
fi

# Search git log for any commits mentioning bind, server config, or issue `#275`
echo -e "\n=== Searching for commits related to server bind or issue `#275` ==="
git log --all --grep="bind" --grep="server.*config" --grep="#275" --grep="275" --oneline -20

# Check if there are any commits that modified src/server/config.rs recently
echo -e "\n=== Recent commits modifying src/server/config.rs ==="
git log --all --oneline -10 -- src/server/config.rs

Length of output: 1129

---

🏁 Script executed:

#!/bin/bash

# Check the server directory structure
echo "=== Server module structure ==="
tree -L 3 src/server/ 2>/dev/null || find src/server/ -type f -name "*.rs" | head -20

# Look for any config files in the server module
echo -e "\n=== Config-related files in server ==="
fd -e rs . src/server/ | xargs grep -l "bind\|Config" | head -10

# Check src/server/mod.rs to understand the module structure
echo -e "\n=== src/server/mod.rs content ==="
cat src/server/mod.rs

# Search for bind() and bind_listener() methods in all server files
echo -e "\n=== All bind methods in server module ==="
rg -n 'fn bind\(|fn bind_listener\(' src/server/ -A2

Length of output: 7325

---

🏁 Script executed:

#!/bin/bash

# Read the full binding.rs file to check for duplicated bind logic
echo "=== src/server/config/binding.rs ==="
cat src/server/config/binding.rs

Length of output: 8155

---

🏁 Script executed:

#!/bin/bash

# Close issue `#275` as completed
gh issue close 275 --reason completed --comment "Issue resolved. The duplicated bind logic has been refactored into a single private helper function \`bind_to_listener()\` in \`src/server/config/binding.rs\` (lines 61-94). Both \`Unbound\` and \`Bound\` implementations now delegate to this shared helper, eliminating code duplication and simplifying maintenance as requested."

Length of output: 101

---

@leynos Yes, this issue has been resolved!

After analysing the codebase, I found that the duplicated bind logic has been successfully refactored:

Resolution Summary

The bind logic is now centralised in a single private helper function bind_to_listener() in src/server/config/binding.rs (lines 61-94):

fn bind_to_listener(
    self,
    std_listener: StdTcpListener,
) -> Result<BoundServer<F, T, Ser, Ctx, E, Codec>, ServerError> {
    // ... shared binding logic ...
}

Both the Unbound and Bound implementations now delegate to this helper:

• Unbound (lines 147-176): bind() → bind_existing_listener() → bind_to_listener()
• Bound (lines 233-258): bind() → bind_existing_listener() → bind_to_listener()

This eliminates the code duplication mentioned in the issue and simplifies maintenance exactly as requested.

I've closed issue #275 as completed.